Fix/Enhance IRC Relay colors. Fixes issue #13 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,7 +116,7 @@ void ircsend(ircnet *n, const char *msg, ...) | |||
| } | |||
| } | |||
|
|
|||
| void converttext(char *dst, const char *src) | |||
| void converttext_cube2irc(char *dst, const char *src) | |||
There was a problem hiding this comment.
How about naming these just cube2irc and irc2cube?
- Conforms to mIRC color codes, so most IRC clients should support them correctly. - Normal, white colored Game->IRC text is no longer sent as pure black, but simply with no color code so IRC clients will use their default color. This prevents relayed game text being unreadable in IRC clients with dark backgrounds.
ZeroKnight
force-pushed
the
irc-colors
branch
from
2cc8b67
to
006023d
Compare
Done |
qreeves
added a commit
that referenced
this pull request
Feb 13, 2015
Fix/Enhance IRC Relay colors. Fixes issue #13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correctly.
simply with no color code so IRC clients will use their default color. This
prevents relayed game text being unreadable in IRC clients with dark
backgrounds.