Skip to content

Conversation

anandrkskd
Copy link
Contributor

argocd adds cluster monitoring label if the ns contains openshift- prefix

What type of PR is this?

/kind bug

What does this PR do / why we need it:
This PR fixes the namespace isolation break, caused by using cluster-monitoring label for monitoring
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes GITOPS-6251

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

argocd adds cluster monitoring label if the ns contains openshift- prefix

Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Mar 20, 2025
@openshift-ci openshift-ci bot requested review from sbose78 and varshab1210 March 20, 2025 09:54
@iam-veeramalla
Copy link
Contributor

/lgtm
/approved

@anandrkskd
Copy link
Contributor Author

/retest

Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm label Mar 24, 2025
@varshab1210
Copy link
Member

/retest

Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
@anandrkskd
Copy link
Contributor Author

/retest

@iam-veeramalla
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Apr 3, 2025
Copy link

openshift-ci bot commented Apr 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 3, 2025
@anandrkskd
Copy link
Contributor Author

/test v4.14-kuttl-sequential

3 similar comments
@anandrkskd
Copy link
Contributor Author

/test v4.14-kuttl-sequential

@anandrkskd
Copy link
Contributor Author

/test v4.14-kuttl-sequential

@anandrkskd
Copy link
Contributor Author

/test v4.14-kuttl-sequential

Copy link

openshift-ci bot commented Apr 8, 2025

@anandrkskd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-sequential 2fa6905 link true /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anandrkskd anandrkskd closed this Apr 9, 2025
@anandrkskd
Copy link
Contributor Author

Closing as 1.13 is out of support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants