-
Notifications
You must be signed in to change notification settings - Fork 341
[1.13] fix CVE namespace-isolation break CVE-13484 #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
argocd adds cluster monitoring label if the ns contains openshift- prefix Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
/lgtm |
/retest |
/retest |
Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iam-veeramalla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test v4.14-kuttl-sequential |
3 similar comments
/test v4.14-kuttl-sequential |
/test v4.14-kuttl-sequential |
/test v4.14-kuttl-sequential |
@anandrkskd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Closing as 1.13 is out of support. |
argocd adds cluster monitoring label if the ns contains openshift- prefix
What type of PR is this?
/kind bug
What does this PR do / why we need it:
This PR fixes the namespace isolation break, caused by using cluster-monitoring label for monitoring
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes GITOPS-6251
Test acceptance criteria:
How to test changes / Special notes to the reviewer: