[GITOPS-7844]: GitOpsService controller creates default ArgoCD with v1alpha1 api version #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1alpha1 api version Signed-off-by: akhil nittala <nakhil@redhat.com>
|
Skipping CI for Draft Pull Request. |
akhilnittala
requested review from
anandf and
anandrkskd
and removed request for
jannfis
svghadi
reviewed
Oct 6, 2025
svghadi
reviewed
Oct 6, 2025
…1alpha1 api version Signed-off-by: akhil nittala <nakhil@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Creates default argocd with v1beta1
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
http://issues.redhat.com/browse/GITOPS-7844
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
create default argocd instance and also test by deleting it and verify the api version of default argocd