Add default resourceExclusions in ArgoCD Instance #978
Conversation
| // NewCR returns an ArgoCD reference optimized for use in OpenShift | ||
| // with Tekton | ||
| // with comprehensive default resource exclusions | ||
| func NewCR(name, ns string) (*argoapp.ArgoCD, error) { |
There was a problem hiding this comment.
Can you write a unit test for this method ?
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Rizwana777
force-pushed
the
bug-gitops-7953
branch
from
a86cda3 to
583ef8a
Compare
|
/test v4.14-kuttl-sequential |
|
/lgtm |
|
/cherry-pick v1.18 |
|
@svghadi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks @Rizwana777. Please rebase your changes, so that it can be merged. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
openshift-merge-bot
bot
merged commit dc9c12c
into
redhat-developer:master
|
@svghadi: new pull request created: #982 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Updated default resourceExclusions in ArgoCD Instance including existing tekton exclusions
JIRA - https://issues.redhat.com/browse/GITOPS-7953