Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around vsce refusal to publish extensions with proposed API #2854

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

rgrunber
Copy link
Member

@rgrunber rgrunber commented Jan 4, 2023

  • enabledApiProposals is removed, and enablement can be controlled at the platform level

Signed-off-by: Roland Grunberg rgrunber@redhat.com

We haven't been publishing the paste feature in pre-releases because :

03:16:03   ERROR  Extensions using proposed API (enabledApiProposals: [...]) can't be published to the Marketplace

See https://github.com/microsoft/vscode-vsce/blob/8b49e9dfdf909ad3af2b9ec9c825f5b501f6d75e/src/publish.ts#L137-L142

@datho7561, @CsCherrYY can you verify that with this change, it still works ? I would guess that even if the extension declares no proposed api, as long as the platform declares the extension is permitted, it should be fine. (ie. this exists anyways..

product.json

"extensionEnabledApiProposals": {
...
...
"redhat.java": ["documentPaste"]
...
...
}

)

@rgrunber rgrunber added this to the Early January 2023 milestone Jan 4, 2023
@CsCherrYY
Copy link
Contributor

@rgrunber I just tried to install a private bit without enabledApiProposals in package.json, and it still works normally.

- enabledApiProposals is removed, and enablement can be controlled at
  the platform level

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber merged commit 7738468 into redhat-developer:master Jan 5, 2023
@rgrunber rgrunber deleted the disable-proposed-api branch January 5, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants