new readme #11

NikolasKomonen · 2018-08-23T20:36:16Z

No description provided.

fbricon

Can you provide:

a short description,
requirements (Java ...)
a list of supported features

fbricon · 2018-08-23T20:48:46Z

README.md

+
+## Get VSIX Extension
+
+* [Click here](http://download.jboss.org/jbosstools/vscode-xml/staging/) for the latests development VSIX


latest development VSIX archives

fbricon · 2018-08-23T20:49:30Z

README.md

+
+## Get VSIX Extension
+
+* [Click here](http://download.jboss.org/jbosstools/vscode-xml/staging/) for the latests development VSIX


http://download.jboss.org/jbosstools/vscode-xml/staging/?C=M;O=D

NikolasKomonen · 2018-08-24T14:00:02Z

@fbricon updated

fbricon · 2018-08-24T14:02:40Z

README.md

+
+This VSCode extension provides support during the creation of XML documents
+
+## Features


those are LSP features. Users don't care about those. You need to translate to plain English

fbricon · 2018-08-24T14:03:32Z

README.md

@@ -1,9 +1,30 @@
 # VSCode XML Client

+## Description
+
+This VSCode extension provides support during the creation of XML documents


creation and edition.

Finish sentence with a period.

fbricon · 2018-08-24T14:04:32Z

README.md

+
+## Requirements
+
+Java 8/9


we (you) definitely need to fix Java 10 support (See #1)

fbricon · 2018-08-24T14:05:15Z

README.md


 ## Get VSIX Extension

-* [Click here](http://download.jboss.org/jbosstools/vscode-xml/staging/?C=M;O=D) for the latests development VSIX
+* [Click here](http://download.jboss.org/jbosstools/vscode-xml/staging/?C=M;O=D) latest development VSIX archives


for the latest

fbricon · 2018-08-24T14:06:51Z

README.md

+
+## License
+
+  EPL 1.0, See LICENSE file.


there is no LICENSE file, you need to add it

fbricon · 2018-08-24T14:25:20Z

README.md

+
+  This VSCode extension provides creation and edition during the creation of XML documents.
+
+## Get VSIX Extension


merge with installation paragraph

fbricon · 2018-08-24T14:25:35Z

README.md

+    * `java.home` in VSCode preferences
+    * Environment variable `JAVA_HOME` or `JDK_HOME`
+
+## How to Install


Installation

angelozerr · 2018-08-24T15:09:06Z

README.md

+  * Document Folding
+  * Symbols and Renaming
+  * Error Validation
+


And Hover (based on XML Schema) & Format

angelozerr · 2018-08-24T15:09:44Z

README.md

+  * Code completion
+  * Document Folding
+  * Symbols and Renaming
+  * Error Validation


Syntax Error and XML Schema Validation

angelozerr · 2018-08-24T15:09:58Z

README.md

+## Features
+
+  * Start and End Tag highlighting
+  * Code completion


Code completion based on XML Schema Validation

NikolasKomonen · 2018-08-24T18:38:00Z

@fbricon updated with angelo's suggestions, and consideration for all java versions

fbricon · 2018-08-27T15:44:44Z

src/requirements.ts

@@ -79,9 +79,17 @@ function readJavaConfig() : string {
 function checkJavaVersion(java_home: string): Promise<number> {
    return new Promise((resolve, reject) => {
        cp.execFile(java_home + '/bin/java', ['-version'], {}, (error, stdout, stderr) => {


I'll allow the quick n'dirty fix for now, but you should make it more robust eventually, see #1

fbricon · 2018-08-27T15:45:24Z

README.md

+
+## Description
+
+  This VSCode extension provides creation and edition during the creation of XML documents.


creation x 2

fbricon · 2018-08-27T15:46:37Z

README.md

+
+## License
+
+  EPL 1.0, See [LICENSE](https://github.com/NikolasKomonen/vscode-xml/blob/readme/LICENSE) file.


[LICENSE](https://github.com/redhat-developer/vscode-xml/blob/readme/LICENSE)

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>

NikolasKomonen requested a review from fbricon August 23, 2018 20:37

NikolasKomonen force-pushed the readme branch from 31de863 to c59b0d1 Compare August 23, 2018 20:42

fbricon requested changes Aug 23, 2018

View reviewed changes

fbricon reviewed Aug 23, 2018

View reviewed changes

fbricon reviewed Aug 24, 2018

View reviewed changes

README.md Outdated

## Requirements

Java 8/9

Copy link

Collaborator

fbricon Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we (you) definitely need to fix Java 10 support (See #1)

fbricon reviewed Aug 24, 2018

View reviewed changes

README.md Outdated

## License

EPL 1.0, See LICENSE file.

Copy link

Collaborator

fbricon Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no LICENSE file, you need to add it

NikolasKomonen force-pushed the readme branch from 458de12 to 586c794 Compare August 24, 2018 14:18

fbricon reviewed Aug 24, 2018

View reviewed changes

NikolasKomonen force-pushed the readme branch from 3c3c853 to 19c412b Compare August 24, 2018 15:02

angelozerr reviewed Aug 24, 2018

View reviewed changes

NikolasKomonen force-pushed the readme branch from 9c7080f to 5f6f82c Compare August 24, 2018 18:36

fbricon reviewed Aug 27, 2018

View reviewed changes

NikolasKomonen force-pushed the readme branch from 5f6f82c to 86482e4 Compare August 27, 2018 15:47

New README and update to Java Versions

3ef435b

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>

NikolasKomonen force-pushed the readme branch from 86482e4 to 3ef435b Compare August 27, 2018 15:51

fbricon approved these changes Aug 30, 2018

View reviewed changes

fbricon merged commit 42718b5 into redhat-developer:master Aug 30, 2018

NikolasKomonen mentioned this pull request Sep 6, 2018

Add readme #8

Closed

NikolasKomonen deleted the readme branch October 12, 2018 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new readme #11

new readme #11

NikolasKomonen commented Aug 23, 2018

fbricon left a comment

fbricon Aug 23, 2018

fbricon Aug 23, 2018

NikolasKomonen commented Aug 24, 2018

fbricon Aug 24, 2018

fbricon Aug 24, 2018

fbricon Aug 24, 2018

fbricon Aug 24, 2018

fbricon Aug 24, 2018

fbricon Aug 24, 2018

fbricon Aug 24, 2018

angelozerr Aug 24, 2018

angelozerr Aug 24, 2018

angelozerr Aug 24, 2018

NikolasKomonen commented Aug 24, 2018

fbricon Aug 27, 2018 •

edited

Loading

fbricon Aug 27, 2018

fbricon Aug 27, 2018 •

edited

Loading


		## Get VSIX Extension

		* [Click here](http://download.jboss.org/jbosstools/vscode-xml/staging/) for the latests development VSIX


		This VSCode extension provides support during the creation of XML documents

		## Features


		This VSCode extension provides creation and edition during the creation of XML documents.

		## Get VSIX Extension


		## Description

		This VSCode extension provides creation and edition during the creation of XML documents.


		## License

		EPL 1.0, See [LICENSE](https://github.com/NikolasKomonen/vscode-xml/blob/readme/LICENSE) file.

new readme #11

new readme #11

Conversation

NikolasKomonen commented Aug 23, 2018

fbricon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NikolasKomonen commented Aug 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NikolasKomonen commented Aug 24, 2018

fbricon Aug 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fbricon Aug 27, 2018 • edited Loading

Choose a reason for hiding this comment

fbricon Aug 27, 2018 •

edited

Loading

fbricon Aug 27, 2018 •

edited

Loading