Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use %{?systemd_requires} instead of individual Requires for systemd scriptlets #23

Closed
javierpena opened this issue Sep 14, 2017 · 2 comments
Closed

Use %{?systemd_requires} instead of individual Requires for systemd scriptlets #23

javierpena opened this issue Sep 14, 2017 · 2 comments

Comments

@javierpena
Copy link
Member

There are several packages where the runtime systemd requirements to run the post/preun/etc scriptlets are expressed as:

Requires(post): systemd
Requires(preun): systemd
Requires(postun): systemd

We can replace them with a single macro that does the same:

%{?systemd_requires}

One example of this can be found in https://github.com/rdo-packages/nova-distgit/blob/rpm-master/openstack-nova.spec#L116-L118, but there are other packages with the same issue.
@snecklifter snecklifter self-assigned this Sep 15, 2017
@snecklifter
Copy link
Contributor

@javierpena these are all done (I think!)

rdoproject pushed a commit to rdo-packages/cloudkitty-distgit that referenced this issue Sep 18, 2017
@snecklifter
convert individual requires to macro
1ced551 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I27c12f9ef909661305f74d507bb6694e19ec1906
rdoproject pushed a commit to rdo-packages/ceilometer-distgit that referenced this issue Sep 18, 2017
@snecklifter @hguemar
convert individual requires to macro
08683e5 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I4b66ad54e05f569fee426d6071497818d04c113a
rdoproject pushed a commit to rdo-packages/manila-distgit that referenced this issue Sep 18, 2017
@snecklifter @hguemar
convert individual requires to macro
aff68d9 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I43f6b647022ac2b4208b411bc92ad581297aa5bc
rdoproject pushed a commit to rdo-packages/os-collect-config-distgit that referenced this issue Sep 19, 2017
@snecklifter
convert individual requires to macro
d8cf264 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I4e40e864e6bfa3a77ce3f3007bb5357b4ddfd545
rdoproject pushed a commit to rdo-packages/novajoin-distgit that referenced this issue Sep 19, 2017
@snecklifter
convert individual requires to macro
508f28a 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I6994f1bdc3b4287e8146d7c7637702f5499d5dd3
rdoproject pushed a commit to rdo-packages/heat-distgit that referenced this issue Sep 19, 2017
@snecklifter
convert individual requires to macro
654acc2 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I99110b801ca2b586572e278e2fcb76697092c429
rdoproject pushed a commit to rdo-packages/neutron-distgit that referenced this issue Sep 19, 2017
@snecklifter
convert individual requires to macro
dadd8eb 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: Ic349dc43bd969f17a3d6c66ed3ab134268994d7e
rdoproject pushed a commit to rdo-packages/octavia-distgit that referenced this issue Sep 19, 2017
@snecklifter
convert individual requires to macro
0f3ebf1 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I9ada4fc31b3a15aea0b91e9af5d4f2addbd2e1dc
rdoproject pushed a commit to rdo-packages/networking-bigswitch-distgit that referenced this issue Sep 19, 2017
@snecklifter
convert individual requires to macro
e3d6dea 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: Ia016d561205e5ab892dec92985c47eda114c94cd
rdoproject pushed a commit to rdo-packages/glare-distgit that referenced this issue Sep 21, 2017
@snecklifter
convert individual requires to macro
f1920e5 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I797b095627fbdb0026dae4d7a06a944e2572620c
rdoproject pushed a commit to rdo-packages/nova-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
d08fd98 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: Ic45ddb7a50a480b32f8aa857ed9b393b335dc6f3
rdoproject pushed a commit to rdo-packages/cinder-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
9a7acc6 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I9de7c8a2b1c722075bfb0767551b43f03b3d190c
rdoproject pushed a commit to rdo-packages/magnum-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
61e4617 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: Id5312ec541c8fc39a958ea2fbf8a5ad584462e66
rdoproject pushed a commit to rdo-packages/sahara-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
597ff82 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I6e07842aaae8194328b69823c2b85663013cd701
rdoproject pushed a commit to rdo-packages/glance-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
b3015b3 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I4df84feeb10c8bd6fc97161ec1a336b892fe7884
rdoproject pushed a commit to rdo-packages/trove-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
90137d6 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I7091190b19dcbf91d64b2a5aad1a58d802858ae1
rdoproject pushed a commit to rdo-packages/murano-agent-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
81aa9ce 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I15256abe62ef1e3f30e4b4cec89200bd9bafc923
rdoproject pushed a commit to rdo-packages/keystone-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
dfa44db 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: Ia0fa6767cb37ce5c4bed772f3c91e66c32390bca
rdoproject pushed a commit to rdo-packages/ironic-distgit that referenced this issue Sep 26, 2017
@adityaramteke
convert individual requires to macro.
dd084a4 
redhat-openstack/easyfix#23

Change-Id: Idff4063b4ef243586df8a2beb5f28e7b966136a1
rdoproject pushed a commit to rdo-packages/swift-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
5515bfe 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: If3f7b05a5eaf10c82a99e6b9ceae1fd6e8e16c6d
rdoproject pushed a commit to rdo-packages/cisco-ironic-contrib-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
024150e 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I99cfc10da98e5b1cb3ba512cf45846490fdd7ab0
rdoproject pushed a commit to rdo-packages/networking-cisco-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
a6942a6 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I933c95f70eac48d3f08aa1aa354e86492a0a95bd
rdoproject pushed a commit to rdo-packages/watcher-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
2f3d1a7 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: Ia29f8d4332598b5d31048bc6a49d30bc874dbef8
rdoproject pushed a commit to rdo-packages/kuryr-kubernetes-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
2cc4400 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: Ife0008fe6ac39e4db9a9431f4f9715d4e38dd1b4
rdoproject pushed a commit to rdo-packages/ironic-inspector-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
0681dd5 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I93eb8a11eda49ac6bad6407cafd42d67b3b323e9
rdoproject pushed a commit to rdo-packages/designate-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
202fe89 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I85183ed0d696a3e650d68787f4b844c369e208ad
rdoproject pushed a commit to rdo-packages/vitrage-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
d91a5bb 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I59541c1de6b494f0ad8a73bf87bcb5f17480a9c5
rdoproject pushed a commit to rdo-packages/tacker-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
ac1435f 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I8302773569d004918387a9f78ca355add0dbfc78
rdoproject pushed a commit to rdo-packages/aodh-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
8f45833 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: Ic07af9cff550503cfc74a550891fe4956d53eda8
rdoproject pushed a commit to rdo-packages/barbican-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
b0c46ab 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I73ca9c3a309891716803a4d5c62ec267f8d95205
rdoproject pushed a commit to rdo-packages/ironic-python-agent-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
0755363 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I8baf229804d193de28285feacfef1865eefff48f
rdoproject pushed a commit to rdo-packages/ironic-distgit that referenced this issue Sep 26, 2017
@snecklifter
convert individual requires to macro
875941f 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: Ib5c6978fdb254fbcef2f46552b384f2a39803514
rdoproject pushed a commit to rdo-packages/congress-distgit that referenced this issue Sep 26, 2017
@snecklifter @chkumar246
convert individual requires to macro
ac4b16e 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: Ia620e76ab14f24ad2398dafa46ed912fddcbf037
rdoproject pushed a commit to rdo-packages/zaqar-distgit that referenced this issue Sep 26, 2017
@snecklifter @amoralej
convert individual requires to macro
f36c21c 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I972716257bfa9291ee321300b84dde415aa24c8d
@snecklifter
Copy link
Contributor

Done and dusted. :)

@snecklifter snecklifter removed their assignment Sep 27, 2017
rdoproject pushed a commit to rdo-packages/networking-cisco-distgit that referenced this issue Sep 10, 2018
@snecklifter @yazug
convert individual requires to macro
28fbcf5 
This removes post/preun/postun scriptlets to a single macro

redhat-openstack/easyfix#23

Change-Id: I933c95f70eac48d3f08aa1aa354e86492a0a95bd
(cherry picked from commit a6942a6)
@istiak101 istiak101 mentioned this issue Dec 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@javierpena @snecklifter