Remove pbench and Add PCP #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This remove pbench code paths as it is no longer supported Co-developed-by: Cursor
This adds pcp data reporting so all test results are supplied in pyperf_$TESTNAME. All of these values are reported in seconds to make displaying them in future visualizations easier. Co-developed-by: Cursor
|
This relates to RPOPC-620 |
dvalinrh
requested changes
Sep 23, 2025
pyperf/pyperf_run
Outdated
| # Process the data. | ||
| # | ||
| ${curdir}/test_tools/save_results --curdir $curdir --home_root $to_home_root --results /tmp/pyperf.out --test_name pyperf --tuned_setting=$to_tuned_setting --version NONE --user $to_user --other_files "python_results/*,test_results_report" | ||
| ${curdir}/test_tools/save_results --curdir $curdir --home_root $to_home_root --results /tmp/pyperf.out --test_name pyperf --tuned_setting=$to_tuned_setting --version NONE --user $to_user --other_files "python_results/*,test_results_report,$pcp_dir" |
There was a problem hiding this comment.
pcpdir is either null or a directory. Need to use --copy_dir if it exists.
Move pcp_dir to copy_dir arguments in save_results per code review comments.
dvalinrh
approved these changes
Sep 30, 2025
dvalinrh
added
the
group_review_lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes Pbench support since it is no longer supported by test-tools and Zathras as a whole, and introduces PCP archive recording to replace some of pbench's system metrics.
Additionally all test results are reported within the PCP archive under openmetrics.workload.pyperf_$TESTNAME
Before/After Comparison
Before
Pbench is present, but likely broken due to deprecation.
After
Pbench is removed, and PCP is gathering system metrics.
Clerical Stuff
this closes #49 and closes #50
Relates to JIRA: RPOPC-620
Relates to JIRA: RPOPC-619