(#1719364) Always use inactive_exit_timestamp if it is set #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd-rhel-bot
changed the title
|
Tracker - 1719364 The following commits meet all requirements
|
If we're doing a daemon-reload, we'll be going from TIMER_DEAD => TIMER_WAITING, so we won't use inactive_exit_timestamp because TIMER_DEAD != UNIT_ACTIVE, even though inactive_exit_timestamp is serialized/deserialized and will be valid after the daemon-reload. This issue can lead to timers never firing as we'll always calculate the next elapse based on the current realtime on daemon-reload, so if daemon-reload happens often enough, the elapse interval will be moved into the future every time, which means the timer will never trigger. To fix the issue, let's always use inactive_exit_timestamp if it is set, and only fall back to the current realtime if it is not set. (cherry picked from commit 6546045fa0bf84737bd8b2e1e8bf7dd3941d8352) Resolves: #1719364
(cherry picked from commit e21f75afcd95a46261a36a2614712eff6bc119f4) Related: #1719364
dtardon
force-pushed
the
bz1719374-OnCalendar+RandomizedDelaySec
branch
from
483cf11 to
db767ab
Compare
dtardon
changed the title
systemd-rhel-bot
changed the title
|
@dtardon, it's the next step to check Bugzilla/Jira and look for revert commits and possibly follow-ups. I hope to deliver such functionality soonish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1719364