Skip to content

Conversation

abrookins
Copy link
Contributor

@abrookins abrookins commented Nov 12, 2021

Add a tutorial for Redis OM for Python.

@simonprickett
Copy link
Contributor

@abrookins ping me when this is ready and I'll take a look, thanks!

@simonprickett simonprickett added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 17, 2021
@abrookins
Copy link
Contributor Author

@simonprickett This is ready to review!

Copy link
Contributor

@simonprickett simonprickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abrookins looks good to me - left one small suggested commit to adjust the level of one heading to be in line with its sibling in the Docker section. My only other thought was do you want to add a link to the Redis OM Python GitHub repo somewhere in this article, I don't think I saw one.

@simonprickett simonprickett marked this pull request as ready for review November 24, 2021 17:44
@simonprickett
Copy link
Contributor

@abrookins FYI I updated the status here from draft to ready for review. I reviewed it, I think you're good to go.

@simonprickett
Copy link
Contributor

@abrookins I fixed the merge conflict with the authors list in the docusaurus config file.

Andrew Brookins and others added 3 commits November 24, 2021 10:13
Co-authored-by: Simon Prickett <simon@redislabs.com>
@abrookins
Copy link
Contributor Author

Thanks for your sharp eye and all your help, @simonprickett !

@abrookins abrookins merged commit 0f5eaba into master Nov 24, 2021
@SuzeShardlow SuzeShardlow deleted the redis-om-python branch November 26, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants