Skip to content

Fixed compare utility after redis-py > 4 change #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Fixed compare utility after redis-py > 4 change #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions redisbench_admin/compare/compare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ def compare_command_logic(args, project_name, project_version):
total_stable = 0
total_unstable = 0
total_regressions = 0
noise_waterline = 2.5
for test_name in test_names:

test_name = test_name.decode()
Expand Down Expand Up @@ -175,7 +176,9 @@ def compare_command_logic(args, project_name, project_version):

note = ""
try:
baseline_datapoints = rts.revrange(ts_name_baseline, from_ts_ms, to_ts_ms)
baseline_datapoints = rts.ts().revrange(
ts_name_baseline, from_ts_ms, to_ts_ms
)
baseline_nsamples = len(baseline_datapoints)
if baseline_nsamples > 0:
_, baseline_v = baseline_datapoints[0]
Expand All @@ -188,7 +191,7 @@ def compare_command_logic(args, project_name, project_version):
baseline_pct_change = (baseline_std / baseline_median) * 100.0
largest_variance = baseline_pct_change

comparison_datapoints = rts.revrange(
comparison_datapoints = rts.ts().revrange(
ts_name_comparison, from_ts_ms, to_ts_ms
)
comparison_nsamples = len(comparison_datapoints)
Expand Down Expand Up @@ -247,15 +250,15 @@ def compare_command_logic(args, project_name, project_version):
detected_regression = True
total_regressions = total_regressions + 1
note = note + " REGRESSION"
else:
elif percentage_change < -noise_waterline:
note = note + " potential REGRESSION"
detected_regressions.append(test_name)
if percentage_change > 0.0 and not unstable:
if percentage_change > waterline:
detected_improvement = True
total_improvements = total_improvements + 1
note = note + " IMPROVEMENT"
else:
elif percentage_change > noise_waterline:
note = note + " potential IMPROVEMENT"

if (
Expand Down