Skip to content

Fixed local redis-benchmark run args #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 18, 2021
Merged

Fixed local redis-benchmark run args #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
43361fb
[wip] YCSB local run ( requires post processing of results )
filipecosta90 Apr 18, 2021
56365db
[WIP] Enabling YCSB remote run
filipecosta90 Apr 18, 2021
10bbdcf
[add] Made tool source remote config more verbose/easy to use
filipecosta90 Apr 18, 2021
f56c570
Bumping version from 0.1.62 to 0.1.63
filipecosta90 Apr 18, 2021
0972477
Merge remote-tracking branch 'origin/master' into ycsb.local.support
filipecosta90 Apr 18, 2021
14a1148
[fix] Fixed local redis-benchmark run args
filipecosta90 Apr 18, 2021
1da68ba
Bumping version from 0.1.63 to 0.1.64
filipecosta90 Apr 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "redisbench-admin"
version = "0.1.63"
version = "0.1.64"
description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
authors = ["filipecosta90 <filipecosta.90@gmail.com>"]
readme = "README.md"
Expand Down
7 changes: 4 additions & 3 deletions redisbench_admin/run/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,10 @@ def prepare_benchmark_parameters(
command_arr, command_str = prepare_redis_benchmark_command(
benchmark_tool, server_private_ip, server_plaintext_port, entry
)
redirect_file = ">{}".format(remote_results_file)
command_arr.append(redirect_file)
command_str = command_str + " " + redirect_file
if isremote is True:
redirect_file = "> {}".format(remote_results_file)
command_arr.append(redirect_file)
command_str = command_str + " " + redirect_file

if "redisgraph-benchmark-go" in benchmark_tool:
if isremote is True:
Expand Down