Add unit test/comment for multi/exec handling #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a mulit/exec command, the results of `call_pipelined` can be an array. It was not obvious to me this was handled outside of the `ConnectionMixin`. This commit adds a unit test to ensure the commands for an error are stored properly in this case and a comment mentioning that the results are handled in `Multi#_coerce!`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a mulit/exec command, the results of
call_pipelinedcan be an array. It was not obvious to me this was handled outside of theConnectionMixin. This commit adds a unit test to ensure the commands for an error are stored properly in this case and a comment mentioning that the results are handled inMulti#_coerce!.