Skip to content

confirm iframe fix #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 9, 2022
Merged

confirm iframe fix #1134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a88c61
confirm iframe fix
Sep 8, 2022
f52069c
unskipped tests with ft.search
vlad-dargel Sep 8, 2022
93b5c18
delete .only
vlad-dargel Sep 9, 2022
f03cb66
upd of circleci config
vlad-dargel Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions tests/e2e/tests/critical-path/workbench/command-results.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ test('Verify that user can see the results found in the table view by default fo
await t.expect(await workbenchPage.queryCardContainer.nth(0).find(workbenchPage.cssTableViewTypeOption).visible).ok(`The table view is selected by default for command ${command}`);
}
});
test
.meta({ env: env.desktop })('Verify that user can switches between views and see results according to the view rules in Workbench in results', async t => {
test('Verify that user can switches between views and see results according to the view rules in Workbench in results', async t => {
indexName = chance.word({ length: 5 });
const commands = [
'hset doc:10 title "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud" url "redis.io" author "Test" rate "undefined" review "0" comment "Test comment"',
Expand All @@ -92,9 +91,8 @@ test
await workbenchPage.selectViewTypeText();
await t.expect(await workbenchPage.queryCardContainer.nth(0).find(workbenchPage.cssQueryTextResult).visible).ok('The result is displayed in Text view');
});
//skipped due the inaccessibility of the iframe
test.skip
.meta({ env: env.desktop })('Verify that user can switches between Table and Text for Client List and see results corresponding to their views', async t => {
// Skipped due to issue https://redislabs.atlassian.net/browse/RI-3524
test.skip('Verify that user can switches between Table and Text for Client List and see results corresponding to their views', async t => {
const command = 'CLIENT LIST';
//Send command and check table view is default
await workbenchPage.sendCommandInWorkbench(command);
Expand Down
6 changes: 3 additions & 3 deletions tests/e2e/tests/critical-path/workbench/default-scripts-area.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ fixture `Default scripts area at Workbench`
await deleteStandaloneDatabaseApi(ossStandaloneRedisearch);
});
test
.meta({ env: env.desktop, rte: rte.standalone })('Verify that user can edit and run automatically added "FT._LIST" and "FT.INFO {index}" scripts in Workbench and see the results', async t => {
.meta({ rte: rte.standalone })('Verify that user can edit and run automatically added "FT._LIST" and "FT.INFO {index}" scripts in Workbench and see the results', async t => {
indexName = chance.word({ length: 5 });
keyName = chance.word({ length: 5 });
const commandsForSend = [
Expand Down Expand Up @@ -55,7 +55,7 @@ test
await t.expect(workbenchPage.queryColumns.textContent).contains('name', 'The result of the FT.INFO command');
});
test
.meta({ env: env.desktop, rte: rte.standalone })('Verify that user can edit and run automatically added "Search" script in Workbench and see the results', async t => {
.meta({ rte: rte.standalone })('Verify that user can edit and run automatically added "Search" script in Workbench and see the results', async t => {
indexName = chance.word({ length: 5 });
keyName = chance.word({ length: 5 });
const commandsForSend = [
Expand All @@ -80,7 +80,7 @@ test
await t.expect(name.exists).ok('The added key name field is in the Search result');
});
test
.meta({ env: env.desktop, rte: rte.standalone })('Verify that user can edit and run automatically added "Aggregate" script in Workbench and see the results', async t => {
.meta({ rte: rte.standalone })('Verify that user can edit and run automatically added "Aggregate" script in Workbench and see the results', async t => {
indexName = chance.word({ length: 5 });
const aggregationResultField = 'max_price';
const commandsForSend = [
Expand Down
8 changes: 4 additions & 4 deletions tests/e2e/tests/regression/workbench/command-results.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ const commandsForIndex = [
'HMSET product:1 price 20',
'HMSET product:2 price 100'
];
// skip due to errors of FT.SEARCH issue https://redislabs.atlassian.net/browse/RI-3501
fixture.skip `Command results at Workbench`

fixture `Command results at Workbench`
.meta({type: 'regression', rte: rte.standalone })
.page(commonUrl)
.beforeEach(async t => {
Expand Down Expand Up @@ -72,8 +72,8 @@ test
await t.switchToIframe(workbenchPage.iframe);
await t.expect(await workbenchPage.queryTableResult.exists).ok('The table view is not switched for command FT.AGGREGATE');
});
// skip due to inaccessibility of CLIENT LIST in plugin
test
// Skipped due to issue https://redislabs.atlassian.net/browse/RI-3524
test.skip
.meta({ env: env.web })('Verify that user can switches between views and see results according to this view in full mode in Workbench', async t => {
const command = 'CLIENT LIST';
//Send command and check table view is default in full mode
Expand Down
3 changes: 1 addition & 2 deletions tests/e2e/tests/regression/workbench/raw-mode.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,7 @@ test
await t.switchToMainWindow();
await workbenchPage.sendCommandInWorkbench(`FT.DROPINDEX ${indexName} DD`);
await deleteStandaloneDatabaseApi(ossStandaloneRedisearch);
})
.meta({ env: env.desktop })('Display Raw mode for plugins', async t => {
})('Display Raw mode for plugins', async t => {
const commandsForSend = [
`FT.CREATE ${indexName} ON HASH PREFIX 1 product: SCHEMA name TEXT`,
`HMSET product:1 name "${unicodeValue}"`,
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/regression/workbench/scripting-area.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const settingsPage = new SettingsPage();
const indexName = chance.word({ length: 5 });
let keyName = chance.word({ length: 10 });

fixture`Scripting area at Workbench`
fixture `Scripting area at Workbench`
.meta({ type: 'regression' })
.page(commonUrl)
.beforeEach(async t => {
Expand Down