Skip to content

fix slow log configuration #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2022
+4 −4
Merged

fix slow log configuration #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/e2e/pageObjects/slow-log-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export class SlowLogPage {
slowLogCommandValue = Selector('[data-testid=command-value]');
slowLogEmptyResult = Selector('[data-testid=empty-slow-log]');
slowLogCommandStatistics = Selector('[data-testid=entries-from-timestamp]');
configInfo = Selector('[data-testid=config-info]');
// Table
slowLogTable = Selector('[data-testid=slowlog-table]');

Expand Down
7 changes: 3 additions & 4 deletions tests/e2e/tests/critical-path/slow-log/slow-log.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,7 @@ test('Verify that user can reset settings to default on Slow Log page', async t
await slowLogPage.changeMaxLengthParameter(maxCommandLength);
// Reset settings to default
await slowLogPage.resetToDefaultConfig();
// Open Slow Log configuration and check default settings
await t.expect(slowLogPage.slowLogSlowerThanConfig.withAttribute('value', '10000').exists).ok('Default Slower Than');
await t.expect(slowLogPage.slowLogMaxLengthConfig.withAttribute('value', '128').exists).ok('Default Max Length');
await t.expect(slowLogPage.slowLogConfigureUnitButton.withExactText('µs').exists).ok('Default Slower Than');
// Compare configuration after re-setting
const configText = await slowLogPage.configInfo.textContent;
await t.expect(configText.replace(/\u00a0/g, ' ')).contains('Execution time: 10 000 µs, Max length: 128', 'Not reset configuration');
});