Skip to content

#RI-3583-update parse group response #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2022
Merged

#RI-3583-update parse group response #1189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redisinsight/ui/src/components/query-card/QueryCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export interface Props {
isOpen: boolean
result: Maybe<CommandExecutionResult[]>
activeMode: RunQueryMode
mode: RunQueryMode
mode?: RunQueryMode
activeResultsMode?: ResultsMode
resultsMode?: ResultsMode
emptyCommand: boolean
Expand Down
5 changes: 3 additions & 2 deletions redisinsight/ui/src/components/query-card/QueryCardCliResultWrapper/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,11 @@
}

.container .alert {
font-size: 13px !important;
line-height: 18px !important;
font-size: 14px !important;
line-height: 17px !important;
letter-spacing: -0.13px !important;
color: var(--euiColorWarningLight) !important;
margin-bottom: 4px;
}

.container .alertIcon {
Expand Down
2 changes: 1 addition & 1 deletion redisinsight/ui/src/components/query-card/QueryCardHeader/QueryCardHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export interface Props {
createdAt?: Date
summaryText?: string
activeMode: RunQueryMode
mode: RunQueryMode
mode?: RunQueryMode
activeResultsMode?: ResultsMode
summary?: string
queryType: WBQueryType
Expand Down
17 changes: 2 additions & 15 deletions redisinsight/ui/src/utils/cliHelper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,19 +88,6 @@ const wbSummaryCommand = (command: string) => (
</span>
)

const wbSummaryCommandResult = (result: string, status: CommandExecutionStatus) => (
<span
className={
status === CommandExecutionStatus.Success
? `${CliPrefix.Cli}-output-response-success`
: `${CliPrefix.Cli}-output-response-fail`
}
data-testid="wb-command-result"
>
{`${result} \n`}
</span>
)

const clearOutput = (dispatch: any) => {
dispatch(resetOutput())
}
Expand All @@ -110,12 +97,12 @@ const cliParseCommandsGroupResult = (
index: number
) => {
const executionCommand = wbSummaryCommand(result.command)
const executionResult = wbSummaryCommandResult(result.response || '(nil)', result.status)

const executionResult = cliParseTextResponse(result.response || '(nil)', result.command, result.status)
return (
<Fragment key={`group-result-${index}`}>
{executionCommand}
{executionResult}
{'\n'}
</Fragment>
)
}
Expand Down