e2e - Command results at Workbench #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofersteinberg
suggested changes
Dec 16, 2021
| await t.click(this.textViewTypeOption); | ||
| } | ||
|
|
||
| //Select Tab;e view option in Workbench results |
Comment on lines
26
to
35
| await userAgreementPage.acceptLicenseTerms(); | ||
| await t.expect(addRedisDatabasePage.addDatabaseButton.exists).ok('The add redis database view', {timeout: 20000}); | ||
| await addNewStandaloneDatabase(ossStandaloneConfig); | ||
| //Connect to DB | ||
| await myRedisDatabasePage.clickOnDBByName(ossStandaloneConfig.databaseName); | ||
| //Add index and data | ||
| await t.click(myRedisDatabasePage.workbenchButton); | ||
| for(let command of commandsForIndex) { | ||
| await workbenchPage.sendCommandInWorkbench(command); | ||
| } |
There was a problem hiding this comment.
If all of this, of part of it, exists on other tests, let's make one function in common actions.
| await workbenchPage.sendCommandInWorkbench(command); | ||
| } | ||
| }) | ||
| .afterEach(async t => { |
| await myRedisDatabasePage.deleteAllDatabases(); | ||
| }) | ||
| //skipped due the inaccessibility of the iframe | ||
| test.skip('Verify that user can switches between Table and Text for FT.INFO and see results corresponding to their views', async t => { |
There was a problem hiding this comment.
You could set 1 skip on the fixture, instead of on each test
ofersteinberg
previously approved these changes
Dec 21, 2021
ofersteinberg
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.