Skip to content

return null instead of undefined #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2022
Merged

return null instead of undefined #1257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7c50fa
return null instead of undefined
Oct 6, 2022
46d960c
fix logic: return null in case of error only.
Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...ht/api/src/modules/browser/services/keys-business/scanner/strategies/abstract.strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export abstract class AbstractStrategy implements IScannerStrategy {
new Command(BrowserToolKeysCommands.Ttl, [key], { replyEncoding: 'utf8' }),
) as number;
} catch (e) {
// ignore error
ttl = null;
}

try {
Expand All @@ -79,15 +79,15 @@ export abstract class AbstractStrategy implements IScannerStrategy {
),
) as number;
} catch (e) {
// ignore error
size = null;
}

try {
type = filterType || await client.sendCommand(
new Command(BrowserToolKeysCommands.Type, [key], { replyEncoding: 'utf8' }),
) as string;
} catch (e) {
// ignore error
type = null;
}

return {
Expand Down Expand Up @@ -128,7 +128,7 @@ export abstract class AbstractStrategy implements IScannerStrategy {
if (transactionError) {
throw transactionError;
} else {
return transactionResults.map((item: [ReplyError, any]) => item[1]);
return transactionResults.map((item: [ReplyError, any]) => item[0] ? null : item[1]);
}
}

Expand All @@ -146,7 +146,7 @@ export abstract class AbstractStrategy implements IScannerStrategy {
if (transactionError) {
throw transactionError;
} else {
return transactionResults.map((item: [ReplyError, any]) => item[1]);
return transactionResults.map((item: [ReplyError, any]) => item[0] ? null : item[1]);
}
}

Expand All @@ -171,7 +171,7 @@ export abstract class AbstractStrategy implements IScannerStrategy {
if (transactionError) {
throw transactionError;
} else {
return transactionResults.map((item: [ReplyError, any]) => item[1]);
return transactionResults.map((item: [ReplyError, any]) => item[0] ? null : item[1]);
}
}
}