Skip to content

Conversation

vlad-dargel
Copy link
Contributor

@vlad-dargel vlad-dargel commented Oct 11, 2022

Refactoring of e2e critical-path tests from https://redislabs.atlassian.net/browse/RI-3530
Fixed:

  1. Many small tests are merged to save test execution time
  2. Comments are reduced to one formatting
  3. chance.word() replaced by common.generateWord()
  4. Error messages of expects are fixed (previously most of them were incorrect)
  5. "rte: rte.standalone" moved from tests meta to fixture meta
  6. Different updates for some tests

@vlad-dargel vlad-dargel self-assigned this Oct 11, 2022
@CLAassistant
Copy link

CLAassistant commented Oct 11, 2022

CLA assistant check
All committers have signed the CLA.

ofersteinberg
ofersteinberg previously approved these changes Oct 12, 2022
Copy link

@ofersteinberg ofersteinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlad-dargel I went over the first 10 files, and it looks fine.
Notice that it bits overloaded to review such many files. Please write a summery next time on git so I'll have sontext

@vlad-dargel vlad-dargel merged commit 4f0918f into main Oct 13, 2022
@vlad-dargel vlad-dargel deleted the e2e/feature/RI-3530-reduce-number-of-small-e2e branch October 13, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants