#RI-3612-zset infinity score #1285
Conversation
|
|
AmirAllayarovSofteq
changed the title
AmirAllayarovSofteq
requested review from
egor-zalenski,
ArtemHoruzhenko and
rsergeenko
and removed request for
egor-zalenski
| } | ||
|
|
||
| defaultMessage(args: ValidationArguments) { | ||
| return `${args.property || 'field'} must be a string or a number`; |
There was a problem hiding this comment.
must be a string? "hello world" will be not a valid value here...
| BrowserToolZSetCommands.ZScore, | ||
| [keyName, member], | ||
| ); | ||
| const formattedScore = isNaN(parseFloat(score)) ? String(score) : parseFloat(score); |
There was a problem hiding this comment.
Can we move this to some function to not duplicate logic everywhere?
| while (reply.length) { | ||
| const member = reply.splice(0, 2); | ||
| const score = isNaN(parseFloat(member[1])) ? String(member[1]) : parseFloat(member[1]); | ||
| result.push(plainToClass(ZSetMemberDto, { |
There was a problem hiding this comment.
we are using "plainToClass" here. Maybe it is better to create own transformer and isNaN(parseFloat(member[1])) ? String(member[1]) : parseFloat(member[1]); will be done automatically inside?
P.S. See comment above
| name: Joi.string().required(), | ||
| // todo: allow(true) - is incorrect but will be transformed to number by BE. Investigate/fix it | ||
| score: Joi.number().required().allow(true), | ||
| score: Joi.number().required().allow('inf', '-inf').label('.score'), |
There was a problem hiding this comment.
it is better to create own type here the same way as for redisString so it will look like Joi.zSetScore().required() or something similar
| members: Joi.array().items(Joi.object().keys({ | ||
| name: JoiRedisString.required(), | ||
| score: Joi.number().required(), | ||
| score: Joi.number().required().allow('inf', '-inf'), |
| members: Joi.array().items(Joi.object().keys({ | ||
| name: JoiRedisString.required(), | ||
| score: Joi.number().required(), | ||
| score: Joi.number().required().allow('inf', '-inf'), |
| @Type(() => Number) | ||
| score: number; | ||
| @isZSetScore() | ||
| score: number | 'inf' | '-inf'; |
There was a problem hiding this comment.
It is better to create a type (like type ZSetScore = ...) and use it everywhere
No description provided.