Skip to content

#RI-3650 - [FE] 431 status error on get big key #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2022
Merged

#RI-3650 - [FE] 431 status error on get big key #1292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions redisinsight/ui/src/slices/browser/keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,15 +430,18 @@ export function fetchKeys(cursor: string, count: number, onSuccess?: () => void,
const { search: match, filter: type } = state.browser.keys
const { encoding } = state.app.info

const { data, status } = await apiService.get(
const { data, status } = await apiService.post(
getUrl(
state.connections.instances?.connectedInstance?.id ?? '',
ApiEndpoints.KEYS
),
{
params: { cursor, count, type, match: match || DEFAULT_SEARCH_MATCH, encoding },
cursor, count, type, match: match || DEFAULT_SEARCH_MATCH,
},
{
params: { encoding },
cancelToken: sourceKeysFetch.token,
}
},
)

sourceKeysFetch = null
Expand Down Expand Up @@ -513,15 +516,18 @@ export function fetchMoreKeys(oldKeys: IKeyPropTypes[] = [], cursor: string, cou
const state = stateInit()
const { search: match, filter: type } = state.browser.keys
const { encoding } = state.app.info
const { data, status } = await apiService.get(
const { data, status } = await apiService.post(
getUrl(
state.connections.instances?.connectedInstance?.id ?? '',
ApiEndpoints.KEYS
),
{
params: { cursor, count, type, match: match || DEFAULT_SEARCH_MATCH, encoding },
cursor, count, type, match: match || DEFAULT_SEARCH_MATCH,
},
{
params: { encoding },
cancelToken: sourceKeysFetch.token,
}
},
)

sourceKeysFetch = null
Expand Down
8 changes: 4 additions & 4 deletions redisinsight/ui/src/slices/tests/browser/keys.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ describe('keys slice', () => {
status: 200,
}

apiService.get = jest.fn().mockResolvedValue(responsePayload)
apiService.post = jest.fn().mockResolvedValue(responsePayload)

// Act
await store.dispatch<any>(fetchKeys(0, 20))
Expand All @@ -891,7 +891,7 @@ describe('keys slice', () => {
},
}

apiService.get = jest.fn().mockRejectedValue(responsePayload)
apiService.post = jest.fn().mockRejectedValue(responsePayload)

// Act
await store.dispatch<any>(fetchKeys('0', 20))
Expand Down Expand Up @@ -942,7 +942,7 @@ describe('keys slice', () => {
status: 200,
}

apiService.get = jest.fn().mockResolvedValue(responsePayload)
apiService.post = jest.fn().mockResolvedValue(responsePayload)

// Act
await store.dispatch<any>(fetchMoreKeys([], '0', 20))
Expand All @@ -965,7 +965,7 @@ describe('keys slice', () => {
},
}

apiService.get = jest.fn().mockRejectedValue(responsePayload)
apiService.post = jest.fn().mockRejectedValue(responsePayload)

// Act
await store.dispatch<any>(fetchMoreKeys('0', 20))
Expand Down