Skip to content

fix duplication in the indexes list + ignore "MOVED" errors for OSS C… #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022
Merged

fix duplication in the indexes list + ignore "MOVED" errors for OSS C… #1340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions redisinsight/api/src/modules/browser/services/redisearch/redisearch.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Cluster, Command, Redis } from 'ioredis';
import { uniq } from 'lodash';
import {
ConflictException,
Injectable,
Expand Down Expand Up @@ -37,11 +38,11 @@ export class RedisearchService {
const nodes = this.getShards(client);

const res = await Promise.all(nodes.map(async (node) => node.sendCommand(
new Command('FT._LIST'),
new Command('FT._LIST', [], { replyEncoding: 'hex' }),
)));

return plainToClass(ListRedisearchIndexesResponse, {
indexes: [].concat(...res),
indexes: (uniq([].concat(...res))).map((idx) => Buffer.from(idx, 'hex')),
});
} catch (e) {
this.logger.error('Failed to get redisearch indexes', e);
Expand Down Expand Up @@ -103,7 +104,15 @@ export class RedisearchService {
replyEncoding: 'utf8',
});

await Promise.all(nodes.map(async (node) => node.sendCommand(command)));
await Promise.all(nodes.map(async (node) => {
try {
await node.sendCommand(command);
} catch (e) {
if (!e.message.includes('MOVED')) {
throw e;
}
}
}));

return undefined;
} catch (e) {
Expand Down