Skip to content

add tests for top namespaces message #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2022
Merged

add tests for top namespaces message #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redisinsight/ui/src/pages/databaseAnalysis/components/top-namespace/TopNamespace.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const TopNamespace = (props: Props) => {
<h4>TOP NAMESPACES</h4>
</EuiTitle>
</div>
<div className="section-content">
<div className="section-content" data-testid="top-namespaces-message">
<div className={styles.noNamespaceMsg}>
<EuiTitle size="xs">
<span>No namespaces to display</span>
Expand Down
4 changes: 4 additions & 0 deletions tests/e2e/pageObjects/memory-efficiency-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ export class MemoryEfficiencyPage {
scannedKeysInReport = Selector('[data-testid=bulk-delete-summary]');
topKeysTitle = Selector('[data-testid=top-keys-title]');
topKeysKeyName = Selector('[data-testid=top-keys-table-name]');
topNamespacesEmptyContainer = Selector('[data-testid=top-namespaces-empty]');
topNamespacesEmptyMessage = Selector('[data-testid=top-namespaces-message]');
// TABLE
namespaceTable = Selector('[data-testid=nsp-table-memory]');
nameSpaceTableRows = this.namespaceTable.find('[data-testid^=row-]');
Expand All @@ -38,4 +40,6 @@ export class MemoryEfficiencyPage {
thirdPoint = Selector('[data-testid*=bar-43200]');
fourthPoint = Selector('[data-testid*=bar-86400]');
noExpiryPoint = Selector('[data-testid*=bar-0-]:not(rect[data-testid=bar-0-0])');
// LINKS
treeViewLink = Selector('[data-testid=tree-view-page-link]');
}
27 changes: 22 additions & 5 deletions tests/e2e/tests/critical-path/memory-efficiency/memory-efficiency.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { acceptLicenseTermsAndAddDatabaseApi } from '../../../helpers/database';
import { commonUrl, ossStandaloneConfig } from '../../../helpers/conf';
import { deleteStandaloneDatabaseApi } from '../../../helpers/api/api-database';
import { Common } from '../../../helpers/common';
import { Selector } from 'testcafe';

const memoryEfficiencyPage = new MemoryEfficiencyPage();
const myRedisDatabasePage = new MyRedisDatabasePage();
Expand Down Expand Up @@ -62,7 +61,7 @@ test
await browserPage.addStreamKey(streamKeyNameDelimiter, 'field', 'value', keysTTL[2]);
if (await browserPage.submitTooltipBtn.exists) {
await t.click(browserPage.submitTooltipBtn);
};
}
await cliPage.addKeysFromCliWithDelimiter('MSET', 15);
await t.click(browserPage.treeViewButton);
// Go to Analysis Tools page
Expand All @@ -77,6 +76,8 @@ test
await browserPage.deleteKeyByName(streamKeyNameDelimiter);
await deleteStandaloneDatabaseApi(ossStandaloneConfig);
})('Keyspaces displaying in Summary per keyspaces table', async t => {
const noNamespacesMessage = 'No namespaces to displayConfigure the delimiter in Tree View to customize the namespaces displayed.';

// Create new report
await t.click(memoryEfficiencyPage.newReportBtn);
// Verify that up to 15 keyspaces based on the delimiter set in the Tree view are displayed on memory efficiency page
Expand All @@ -100,8 +101,9 @@ test
await t.expect(await browserPage.isKeyIsDisplayedInTheList(streamKeyName)).ok('Key is not found');

// Clear filter
await t.click(browserPage.treeViewButton);
await t.click(browserPage.clearFilterButton);
await t
.click(browserPage.treeViewButton)
.click(browserPage.clearFilterButton);
// Change delimiter
await browserPage.changeDelimiterInTreeView('-');
// Go to Analysis Tools page
Expand All @@ -111,6 +113,21 @@ test
// Verify that delimiter can be changed in Tree View and applied
await t.expect(memoryEfficiencyPage.nameSpaceTableRows.count).eql(1, 'New delimiter not applied');
await t.expect(memoryEfficiencyPage.nameSpaceTableRows.nth(0).textContent).contains(keySpaces[5], 'Keyspace not displayed');

// No namespaces message with link
await t.click(myRedisDatabasePage.browserButton);
// Change delimiter to delimiter with no keys
await browserPage.changeDelimiterInTreeView('+');
// Go to Analysis Tools page and create report
await t
.click(myRedisDatabasePage.analysisPageButton)
.click(memoryEfficiencyPage.newReportBtn);
// Verify that user can see the message when he do not have any namespaces selected in delimiter
await t.expect(memoryEfficiencyPage.topNamespacesEmptyContainer.exists).ok('No namespaces section not displayed');
await t.expect(memoryEfficiencyPage.topNamespacesEmptyMessage.textContent).contains(noNamespacesMessage, 'No namespaces message not displayed/correct');
// Verify that user can redirect to Tree view by clicking on button
await t.click(memoryEfficiencyPage.treeViewLink);
await t.expect(browserPage.treeViewArea.exists).ok('Tree view not opened');
});
test
.before(async t => {
Expand Down Expand Up @@ -200,7 +217,7 @@ test
await browserPage.deleteKeyByName(streamKeyNameDelimiter);
await deleteStandaloneDatabaseApi(ossStandaloneConfig);
})('Summary per expiration time', async t => {
const yAxis: number = 218;
const yAxis = 218;
// Create new report
await t.click(memoryEfficiencyPage.newReportBtn);
// Points are displayed in graph according to their TTL
Expand Down