Skip to content

#RI-3736, #RI-3738 #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2022
Merged

#RI-3736, #RI-3738 #1383

merged 2 commits into from
Nov 15, 2022

Conversation

egor-zalenski
Copy link
Contributor

  • #RI-3736 - Normalize commands in CLI and Workbench
  • #RI-3738 - Module name is Redijson for telemetry events

@egor-zalenski
* #RI-3736 - Normalize commands in CLI and Workbench
1c76769 
* #RI-3738 - Module name is Redijson for telemetry events
@egor-zalenski egor-zalenski self-assigned this Nov 9, 2022
ArtemHoruzhenko
ArtemHoruzhenko approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now, but maybe it is better to do toUppercase in a single place (e..g. check command field inside AnalyticsService and if it is there call toUppercase

@AlenaSY AlenaSY merged commit 315ea06 into feature/RI-3238/prepare_for_docker Nov 15, 2022
@AlenaSY AlenaSY deleted the be/feature/RI-3736_Normalize_telemetry_fields branch November 15, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtemHoruzhenko ArtemHoruzhenko ArtemHoruzhenko approved these changes

Assignees

@egor-zalenski egor-zalenski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@egor-zalenski @ArtemHoruzhenko @AlenaSY