Skip to content

E2e/feature/ri 3483 highlight big keys #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2022
Merged

E2e/feature/ri 3483 highlight big keys #1431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f04d04
Merge branch 'main' into e2e/feature/RI-3483_highlight-big-keys
vlad-dargel Nov 21, 2022
01470f8
add tests for highlight big keys
vlad-dargel Nov 21, 2022
8330268
Merge branch 'feature/RI-3483_highlight-big-keys' into e2e/feature/RI…
vlad-dargel Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/e2e/pageObjects/memory-efficiency-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ export class MemoryEfficiencyPage {
topKeysKeyName = Selector('[data-testid=top-keys-table-name]');
topNamespacesEmptyContainer = Selector('[data-testid=top-namespaces-empty]');
topNamespacesEmptyMessage = Selector('[data-testid=top-namespaces-message]');
topKeysKeySizeCell = Selector('[data-testid^=nsp-usedMemory-value]');
topKeysLengthCell = Selector('[data-testid^=length-value]');
// TABLE
namespaceTable = Selector('[data-testid=nsp-table-memory]');
nameSpaceTableRows = this.namespaceTable.find('[data-testid^=row-]');
Expand Down
28 changes: 27 additions & 1 deletion tests/e2e/tests/critical-path/memory-efficiency/top-keys-table.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,19 @@ import { rte } from '../../../helpers/constants';
import { acceptLicenseTermsAndAddDatabaseApi } from '../../../helpers/database';
import { commonUrl, ossStandaloneRedisearch } from '../../../helpers/conf';
import { deleteStandaloneDatabaseApi } from '../../../helpers/api/api-database';
import { deleteAllKeysFromDB, populateDBWithHashes } from '../../../helpers/keys';
import { deleteAllKeysFromDB, populateDBWithHashes, populateHashWithFields } from '../../../helpers/keys';
import { Common } from '../../../helpers/common';

const memoryEfficiencyPage = new MemoryEfficiencyPage();
const myRedisDatabasePage = new MyRedisDatabasePage();
const browserPage = new BrowserPage();
const cliPage = new CliPage();
const common = new Common();
const chance = new Chance();

const keyToAddParameters = { keysCount: 13, keyNameStartWith: 'hashKey'};
const keyName = `TestHashKey-${common.generateWord(10)}`;
const keyToAddParameters2 = { fieldsCount: 80000, keyName, fieldStartWith: 'hashField', fieldValueStartWith: 'hashValue' };
const members = [...Array(100).keys()].toString().replace(/,/g, ' '); // The smallest key
const keyNamesMemory = ['string', 'list', 'bloom', 'set'];
const keyNamesLength = ['string', 'set', 'list'];
Expand Down Expand Up @@ -66,3 +70,25 @@ test
await t.click(memoryEfficiencyPage.topKeysKeyName.nth(1).find('button'));
await t.expect(browserPage.keyNameFormDetails.find('b').textContent).eql(keyNamesLength[1]);
});
test
.before(async t => {
await acceptLicenseTermsAndAddDatabaseApi(ossStandaloneRedisearch, ossStandaloneRedisearch.databaseName);
// Create keys
await populateHashWithFields('localhost', '8102', keyToAddParameters2);
// Go to Analysis Tools page
await t.click(myRedisDatabasePage.analysisPageButton);
})
.after(async t => {
await t.click(myRedisDatabasePage.browserButton);
await browserPage.deleteKeyByName(keyName);
await deleteStandaloneDatabaseApi(ossStandaloneRedisearch);
})('Big highlighted key tooltip', async t => {
const tooltipText = 'Consider splitting it into multiple keys';

await t.click(memoryEfficiencyPage.newReportBtn);
// Tooltip with text "Consider splitting it into multiple keys" is displayed for highlighted keys
await t.hover(memoryEfficiencyPage.topKeysKeySizeCell);
await t.expect(browserPage.tooltip.textContent).contains(tooltipText, `"${tooltipText}" is not displayed in Key size tooltip`);
await t.hover(memoryEfficiencyPage.topKeysLengthCell);
await t.expect(browserPage.tooltip.textContent).contains(tooltipText, `"${tooltipText}" is not displayed in Length tooltip`);
});