Skip to content

#RI-3940 - When we edit db name, we are getting "new indicator" #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022
Merged

#RI-3940 - When we edit db name, we are getting "new indicator" #1508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions redisinsight/api/src/modules/database/database.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,10 @@ export class DatabaseService {
try {
this.logger.log('Creating new database.');

const database = await this.repository.create(
await this.databaseFactory.createDatabaseModel(classToClass(Database, dto)),
);
const database = await this.repository.create({
...await this.databaseFactory.createDatabaseModel(classToClass(Database, dto)),
new: true,
});

// todo: clarify if we need this and if yes - rethink implementation
try {
Expand Down
1 change: 0 additions & 1 deletion redisinsight/api/src/modules/database/providers/database.factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export class DatabaseFactory {

model.modules = await this.databaseInfoProvider.determineDatabaseModules(client);
model.lastConnection = new Date();
model.new = true

await client.disconnect();

Expand Down
3 changes: 1 addition & 2 deletions redisinsight/api/test/api/database/PUT-databases-id.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,7 @@ describe(`PUT /databases/:id`, () => {
after: async () => {
newDatabase = await localDb.getInstanceById(constants.TEST_INSTANCE_ID_3);
expect(newDatabase).to.contain({
..._.omit(oldDatabase, ['modules', 'provider', 'lastConnection']),
new: true,
..._.omit(oldDatabase, ['modules', 'provider', 'lastConnection', 'new']),
host: constants.TEST_REDIS_HOST,
port: constants.TEST_REDIS_PORT,
});
Expand Down