Skip to content

Update data test-id for monaco editor and eslint #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Update data test-id for monaco editor and eslint #1606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/e2e/pageObjects/browser-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export class BrowserPage {
listKeyElementInput = Selector('[data-testid=element]');
listKeyElementEditorInput = Selector('[data-testid=element-value-editor]');
stringKeyValueInput = Selector('[data-testid=string-value]');
jsonKeyValueInput = Selector('[data-testid=json-value]');
jsonKeyValueInput = Selector('[data-mode-id=json]');
setMemberInput = Selector('[data-testid=member-name]');
zsetMemberScoreInput = Selector('[data-testid=member-score]');
filterByPatterSearchInput = Selector('[data-testid=search-key]');
Expand Down Expand Up @@ -1021,27 +1021,27 @@ export class BrowserPage {
* Get text from first tree element
*/
async getTextFromNthTreeElement(number: number): Promise<string> {
return (await Selector(`[role="treeitem"]`).nth(number).find(`div`).textContent).replace(/\s/g, '');
return (await Selector('[role="treeitem"]').nth(number).find('div').textContent).replace(/\s/g, '');
}

/**
* Open tree folder with multiple level
* @param names folder names with sequence of subfolder
*/
async openTreeFolders(names: string[]): Promise<void> {
let base = `node-item_${names[0]}:`
let base = `node-item_${names[0]}:`;
await t.click(Selector(`[data-testid="${base}"]`));
if (names.length > 1) {
for (let i = 1; i < names.length; i++) {
base = base + `${names[i]}:`;
base = `${base }${names[i]}:`;
await t.click(Selector(`[data-testid="${base}"]`));
}
}
await t.click(Selector(`[data-testid="${base}keys:keys:"]`));

await t.expect(
Selector(`[data-testid="${base}keys:keys:"]`).visible)
.ok("Folder is not selected");
.ok('Folder is not selected');
}

/**
Expand Down