-
Notifications
You must be signed in to change notification settings - Fork 406
E2e/feature/ri 3977 recommendation voting #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nmammadli
merged 6 commits into
feature/RI-3977_recommendation_voting
from
e2e/feature/RI-3977_recommendation_voting
Jan 24, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
109bcc3
Add upvote recommendations test and page object for recommendations
nmammadli 0aabc97
Update recommendations-page.ts
nmammadli d9c1d91
Update recommendations-page.ts
nmammadli af09d55
Update database-recommendations.e2e.ts
nmammadli e4b40fe
Refactor
nmammadli ccf980c
Update memory-efficiency-actions.ts
nmammadli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import {t} from 'testcafe'; | ||
import { MemoryEfficiencyPage } from '../pageObjects'; | ||
|
||
const memoryEfficiencyPage = new MemoryEfficiencyPage(); | ||
export class MemoryEfficiencyActions { | ||
/* | ||
vote for very useful and verify others are disabled | ||
*/ | ||
async voteForVeryUsefulAndVerifyDisabled(): Promise<void> { | ||
await t.click(memoryEfficiencyPage.veryUsefulVoteBtn); | ||
await this.verifyVoteDisabled(); | ||
} | ||
/* | ||
vote for useful and verify others are disabled | ||
*/ | ||
async voteForUsefulAndVerifyDisabled(): Promise<void> { | ||
await t.click(memoryEfficiencyPage.usefulVoteBtn); | ||
await this.verifyVoteDisabled(); | ||
} | ||
/* | ||
vote for not useful and verify others are disabled | ||
*/ | ||
async voteForNotUsefulAndVerifyDisabled(): Promise<void> { | ||
await t.click(memoryEfficiencyPage.notUsefulVoteBtn); | ||
await this.verifyVoteDisabled(); | ||
} | ||
async verifyVoteDisabled(): Promise<void>{ | ||
// Verify that user can rate recommendations with one of 3 existing types at the same time | ||
await t.expect(memoryEfficiencyPage.veryUsefulVoteBtn | ||
.hasAttribute('disabled')).ok('very useful vote button is not disabled'); | ||
await t.expect(memoryEfficiencyPage.usefulVoteBtn | ||
.hasAttribute('disabled')).ok('useful vote button is not disabled'); | ||
await t.expect(memoryEfficiencyPage.notUsefulVoteBtn | ||
.hasAttribute('disabled')).ok('not useful vote button is not disabled'); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need a description for each method here
like:
/**
* Check that voted very useful is disabled
*/