Skip to content

e2e/bugfix fixes for regression #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023
Merged

e2e/bugfix fixes for regression #1623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/e2e/pageObjects/my-redis-databases-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { t, Selector } from 'testcafe';
import { getDatabaseByName } from '../helpers/api/api-database';
import { getDatabaseIdByName } from '../helpers/api/api-database';

export class MyRedisDatabasePage {
//-------------------------------------------------------------------------------------------
Expand Down Expand Up @@ -192,7 +192,7 @@ export class MyRedisDatabasePage {
* @param databaseName The name of the database
*/
async verifyDatabaseStatusIsVisible(databaseName: string): Promise<void> {
const databaseId = await getDatabaseByName(databaseName);
const databaseId = await getDatabaseIdByName(databaseName);
const databaseEditBtn = Selector(`[data-testid=database-status-new-${databaseId}]`);

await t.expect(databaseEditBtn.exists).ok(`Database status is not visible for ${databaseName}`);
Expand All @@ -203,7 +203,7 @@ export class MyRedisDatabasePage {
* @param databaseName The name of the database
*/
async verifyDatabaseStatusIsNotVisible(databaseName: string): Promise<void> {
const databaseId = await getDatabaseByName(databaseName);
const databaseId = await getDatabaseIdByName(databaseName);
const databaseEditBtn = Selector(`[data-testid=database-status-new-${databaseId}]`);

await t.expect(databaseEditBtn.exists).notOk(`Database status is still visible for ${databaseName}`);
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/critical-path/database/import-databases.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ const databasesToDelete = [
];
const findImportedRdmDbNameInList = async(dbName: string): Promise<string> => rdmData.dbImportedNames.find(item => item === dbName)!;

fixture.only `Import databases`
fixture `Import databases`
.meta({ type: 'critical_path', rte: rte.none })
.page(commonUrl)
.beforeEach(async() => {
Expand Down