Skip to content

Conversation

nmammadli
Copy link
Contributor

No description provided.

Copy link
Contributor

@vlad-dargel vlad-dargel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, just need some updates.

And please think about adding some additional tests for Tree view:

  1. When some folder with keys by delimiter selected and user adds a new key without delimiter - key should be displayed in "Keys" root folder
  2. When some folder with keys by delimiter selected and user adds a new key with delimiter from other folder - key should be displayed in other folder and this folder should be selected
  3. When some folder with keys by delimiter selected and user adds a new key with delimiter from the same folder - key should be displayed in the same folder

these cases must necessarily be covered, because this is a rather vulnerable functionality that often breaks

looks like you can add these tests inside the already existing 'Tree view navigations improvement tests'

@nmammadli nmammadli merged commit 7d4095b into feature/RI-3995_add_keys Feb 16, 2023
@nmammadli nmammadli deleted the e2e/feature/RI-3995_add_keys branch February 16, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants