Skip to content

E2E RI-4139 Update visualizations when there is no data to visualize #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2023
Merged

E2E RI-4139 Update visualizations when there is no data to visualize #1752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11be6df
add test for plugin text
vlad-dargel Feb 17, 2023
7dd02ea
selector added
vlad-dargel Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/e2e/pageObjects/workbench-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ export class WorkbenchPage {
//TEXT ELEMENTS
queryPluginResult = Selector('[data-testid=query-plugin-result]');
responseInfo = Selector('[class="responseInfo"]');
parsedRedisReply = Selector('[class="parsedRedisReply"]');
scriptsLines = Selector('[data-testid=query-input-container] .view-lines');
queryCardContainer = Selector('[data-testid^=query-card-container]');
queryCardCommand = Selector('[data-testid=query-card-command]');
Expand Down
7 changes: 6 additions & 1 deletion tests/e2e/tests/regression/workbench/redis-stack-commands.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,16 @@ test
await t.click(workbenchPage.submitCommandButton);
// Check result
await t.switchToIframe(workbenchPage.iframe);
await t.expect(workbenchPage.responseInfo.textContent).eql('No data to visualize. Switch to Text view to see raw information.', 'The info message is not displayed for Graph');
await t.expect(workbenchPage.responseInfo.textContent).eql('No data to visualize. Raw information is presented below.', 'The info message is not displayed for Graph');

// Get result text content
const graphModeText = await workbenchPage.parsedRedisReply.textContent;
// Switch to Text view and check result
await t.switchToMainWindow();
await workbenchPage.selectViewTypeText();
await t.expect(workbenchPage.queryTextResult.exists).ok('The result in text view is not displayed');
// Verify that when there is nothing to visualize in RedisGraph, user can see: No data to visualize.{results from the text view}
await t.expect(workbenchPage.queryTextResult.textContent).eql(graphModeText, 'Text of command in Graph mode is not the same as in Text mode');
});
test('Verify that user can switches between Chart and Text for TimeSeries command and see results corresponding to their views', async t => {
// Send TimeSeries command
Expand Down