[RI-3726] Profile Plugin - Add support for leftoff RediSearch expressions #1781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GnaneshKunal
commented
Feb 26, 2023
GnaneshKunal
commented
- Remove edge target marker
- Add support for LEXRANGE, IDS, NOT, OPTION, EXACT, FUZZY, WILDCARD, and PREFIX expressions (All of the expressions' parsing is based on RediSearch's latest source code) - https://github.com/RediSearch/RediSearch/blob/master/src/query.c
- Parse Vector Expressions
- Parse tag identifiers with numbers
- Properly skip backslash if exsits (multiple backslash appears)
- Parse identifiers with pipe character
- Make TAG expressions be parsed via expand expression parser since it might contain children
- Remove support for FT.PROFILE on cluster
- Add max-cap zoom
- Add support for LEXRANGE, IDS, NOT, OPTION, EXACT, FUZZY, WILDCARD, PREFIX expressions - Parse Vector Expressions - Parse tag identifiers with numbers - Properly skip backslash if exsits (multiple backslash appears) - Parse identifiers with pipe character - Make TAG expressions be parsed via expand expression parser since it might contain children - Remove support for FT.PROFILE on cluster - Add max-cap zoom
rsergeenko
reviewed
Feb 27, 2023
| const [parsedRedisReply, setParsedRedisReply] = useState('') | ||
|
|
||
| useEffect(() => { | ||
| if (command == 'ft.profile') { |
There was a problem hiding this comment.
should be command?.toLowerCase()?
There was a problem hiding this comment.
command is lowercased in line 51.
- Don't prefix simple expressions with '_EXPR' to keep in par with the entity names of the same.
rsergeenko
approved these changes
Feb 27, 2023
- Add geo parsing of negative numbers
…h_styles #RI-4244 - fix workbench icon issue
vlad-dargel
deleted the
fe/bugfix/RI-3726_profile_explain-new-expressions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.