#RI-4284 - Prepare RedisInsight for the Apple Store #1852
Conversation
#RI-4284 - Prepare RedisInsight for the Apple Store
| const homedir = process.env.APP_FOLDER_ABSOLUTE_PATH | ||
| || (join(os.homedir(), process.env.APP_FOLDER_NAME || '.redisinsight-v2')); | ||
| || (join( | ||
| process['mas'] ? `/Users/${getUsername()}` : os.homedir(), |
There was a problem hiding this comment.
does it mean that for all mac builds we will got to /Users//.ri* and this logic is needed because os.homedir for mas builds returns different path?
Also I'm not sure that this is robust solution at all. Is it possible for user to change home dir destination? I guess yes, it is possible. If so - you might have an error that such folder does not exists or permission error
There was a problem hiding this comment.
process.mas is true only for Mac Apple Store (mas), it is an undefined for mac builds
yes, mas build has a different path because of sandbox.
Viktar wants to all mac builds should have the same folder
There was a problem hiding this comment.
But is it possible to have different pattern for user's folder?
Let say i have user reviewer. Are you sure that the user's home folder will be exactly placed into this path /Users/reviewer? Is there a way for user to change his home folder destination?
There was a problem hiding this comment.
Viktar said to remove this logic about single homedir
# Conflicts: # redisinsight/ui/src/packages/clients-list/yarn.lock # redisinsight/ui/src/packages/redisgraph/src/styles/styles.less # redisinsight/ui/src/packages/redistimeseries-app/src/index.html
| applicationName: 'RedisInsight-v2', | ||
| applicationVersion: app.getVersion() || '2.20.0', | ||
| applicationVersion: | ||
| `${app.getVersion() || '2.20.0'}${process.env.NODE_ENV !== 'production' && `-dev-${process.getCreationTime()}`}`, |
There was a problem hiding this comment.
process.getCreationTime()???
There was a problem hiding this comment.
#RI-4284 - Prepare RedisInsight for the Apple Store