Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import styles from './styles.module.scss'

export interface Props {
title?: string | React.ReactNode
subTitle?: string | React.ReactNode
loading: boolean
filter?: Nullable<KeyTypes>
status: Maybe<BulkActionsStatus>
Expand All @@ -23,14 +24,15 @@ export interface Props {
}

const BulkActionsInfo = (props: Props) => {
const { children, loading, filter, search, status, progress, title = 'Delete Keys with' } = props
const { children, loading, filter, search, status, progress, title = 'Delete Keys with', subTitle } = props
const { total = 0, scanned = 0 } = progress || {}

return (
<div className={styles.container} data-testid="bulk-actions-info">
<div className={styles.header}>
<EuiText color="subdued" className={styles.title}>{title}</EuiText>
<EuiText color="subdued" className={styles.subTitle}>
{subTitle}
{filter && (
<div className={styles.filter} data-testid="bulk-actions-info-filter">
<span style={{ paddingRight: 6 }}>Key type:</span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import BulkActionsInfo from 'uiSrc/pages/browser/components/bulk-actions/BulkAct
import BulkActionSummary from 'uiSrc/pages/browser/components/bulk-actions/BulkActionSummary'

import { sendEventTelemetry, TelemetryEvent } from 'uiSrc/telemetry'
import { isProcessedBulkAction } from 'uiSrc/pages/browser/components/bulk-actions/utils'
import styles from './styles.module.scss'

export interface Props {
Expand All @@ -48,6 +49,7 @@ const BulkUpload = (props: Props) => {

const onStartAgain = () => {
dispatch(setBulkUploadStartAgain())
setFiles(null)
}

const handleUploadWarning = () => {
Expand Down Expand Up @@ -120,13 +122,8 @@ const BulkUpload = (props: Props) => {
loading={loading}
status={status}
progress={progress}
title={(
<>
Upload with file
<EuiSpacer size="m" />
<div className="truncateText">{fileName}</div>
</>
)}
title="Upload with file"
subTitle={(<div className="truncateText" style={{ paddingTop: 6 }}>{fileName}</div>)}
>
<BulkActionSummary
succeed={succeed}
Expand All @@ -144,7 +141,7 @@ const BulkUpload = (props: Props) => {
className={styles.cancelBtn}
data-testid="bulk-action-cancel-btn"
>
Cancel
{isProcessedBulkAction(status) ? 'Close' : 'Cancel'}
</EuiButton>
{!isCompleted ? (
<EuiPopover
Expand Down Expand Up @@ -193,6 +190,7 @@ const BulkUpload = (props: Props) => {
) : (
<EuiButton
fill
iconType="refresh"
color="secondary"
onClick={onStartAgain}
data-testid="bulk-action-start-new-btn"
Expand Down
2 changes: 2 additions & 0 deletions redisinsight/ui/src/slices/browser/bulkActions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { ApiEndpoints, BulkActionsType, MAX_BULK_ACTION_ERRORS_LENGTH } from 'ui
import { apiService } from 'uiSrc/services'
import { getApiErrorMessage, getUrl, isStatusSuccessful } from 'uiSrc/utils'

import { addErrorNotification } from 'uiSrc/slices/app/notifications'
import { AppDispatch, RootState } from '../store'
import { StateBulkActions, IBulkActionOverview } from '../interfaces'

Expand Down Expand Up @@ -181,6 +182,7 @@ export function bulkUploadDataAction(
}
} catch (error) {
const errorMessage = getApiErrorMessage(error as AxiosError)
dispatch(addErrorNotification(error as AxiosError))
dispatch(bulkUploadFailed(errorMessage))
onFailAction?.()
}
Expand Down
3 changes: 3 additions & 0 deletions redisinsight/ui/src/slices/tests/browser/bulkActions.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { cloneDeep } from 'lodash'
import { AxiosError } from 'axios'
import { BulkActionsType } from 'uiSrc/constants'
import reducer, {
bulkActionsSelector,
Expand All @@ -22,6 +23,7 @@ import reducer, {
} from 'uiSrc/slices/browser/bulkActions'
import { cleanup, initialStateDefault, mockedStore } from 'uiSrc/utils/test-utils'
import { apiService } from 'uiSrc/services'
import { addErrorNotification } from 'uiSrc/slices/app/notifications'

let store: typeof mockedStore

Expand Down Expand Up @@ -433,6 +435,7 @@ describe('bulkActions slice', () => {
// Assert
const expectedActions = [
bulkUpload(),
addErrorNotification(responsePayload as AxiosError),
bulkUploadFailed(errorMessage),
]
expect(store.getActions()).toEqual(expectedActions)
Expand Down