E2e/feature/ri 4505 migrate to node 18 #2160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/RI-4505_migrate_to_node_18
vlad-dargel
requested review from
ofersteinberg,
egor-zalenski and
mariasergeenko
mariasergeenko
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron works as expected, but web tests failed after migrating to new Electron and Node versions, which was unexpected.
I raised testcafe version to 2.6.2.
But there is an issue with testcafe and nodeJS 18.
DevExpress/testcafe#7753
So I added workaround '--native-automation' which runs tests without testcafe-hammerhead proxy.
But there are some restrictions at this moment, which are described here:
https://testcafe.io/documentation/404237/guides/intermediate-guides/native-automation-mode
That's why I commented some checks on external links for some tests (they are covered by unit tests, so they are not critical)