Skip to content

Release/2.28.0 #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 26, 2023
Merged

Release/2.28.0 #2246

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
11899e9
Merge pull request #2149 from RedisInsight/main
vlad-dargel May 31, 2023
6decfa3
update bundle version
vlad-dargel May 31, 2023
b54bfaa
Merge pull request #2152 from RedisInsight/feature/update-bundle-2-26
vlad-dargel May 31, 2023
4fd3b0a
Merge pull request #2153 from RedisInsight/release/2.26.0
vlad-dargel May 31, 2023
4415b42
Merge branch 'latest' into release/2.28.0
Jun 23, 2023
085173a
Merge pull request #2239 from RedisInsight/main
vlad-dargel Jun 23, 2023
1e21a32
fix disabled field for recommendation
AmirAllayarovSofteq Jun 23, 2023
1a7dcad
Merge pull request #2240 from RedisInsight/bugfix/ws_new_recommendati…
vlad-dargel Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions redisinsight/api/test/api/database-recommendations/WS-new-recommendations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ describe('WS new recommendations', () => {
expect(recommendationsResponse.recommendations[0].name).to.eq('bigSets');
expect(recommendationsResponse.recommendations[0].databaseId).to.eq(constants.TEST_INSTANCE_ID);
expect(recommendationsResponse.recommendations[0].read).to.eq(false);
// expect(recommendationsResponse.recommendations[0].disabled).to.eq(false);
// todo: investigate if it should return false vs undefined
expect(recommendationsResponse.recommendations[0].disabled).to.eq(undefined);
expect(recommendationsResponse.recommendations[0].disabled).to.eq(false);
expect(recommendationsResponse.totalUnread).to.eq(1);
});
});