E2e/bugfix/fixes for desktop tests #2252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-dargel
requested review from
egor-zalenski and
ArtemHoruzhenko
as code owners
mariasergeenko
previously approved these changes
Jun 27, 2023
ArtemHoruzhenko
approved these changes
Jun 28, 2023
| } | ||
|
|
||
| return await requestEndpoint.expect(statusCode); | ||
| } |
There was a problem hiding this comment.
I'm not sure that we need such wrapper.
Is it possible to initiate supertest instance per api service (if needed) or globally with x-window-id header preconfigured like it possible for axios?
It is up to you. Just wanted to highlight this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.