Dependabot fixes #2335
Merged
Dependabot fixes #2335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2023
Closed
- Assert the new error message for enum
GnaneshKunal
force-pushed
the
dependabot-fixes
branch
from
8bfe3b0 to
f080ce8
Compare
ArtemHoruzhenko
requested changes
Jul 19, 2023
package.json
Outdated
| "**/node-sass": "^8.0.0", | ||
| "**/trim": "0.0.3" | ||
| "**/trim": "0.0.3", | ||
| "word-wrap": "npm:@aashutoshrathi/word-wrap", |
There was a problem hiding this comment.
why can't we use 1.2.4 official version?
Also I think we must have some agreement about forks. From my point of view we should use only official libs and in some corner cases we might use OWN forks if it is very critical to fix something.
There was a problem hiding this comment.
UPD: let's use official lib here and in all other places
There was a problem hiding this comment.
Yes. Looks like the official version was just released. Using 1.2.4 from the official library.
GnaneshKunal
force-pushed
the
dependabot-fixes
branch
from
f080ce8 to
cbf2619
Compare
GnaneshKunal
force-pushed
the
dependabot-fixes
branch
from
4255734 to
8c9ab43
Compare
ArtemHoruzhenko
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes