Skip to content

#RI-4718 - fix unhandled error issue in recommendations #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2023
Merged

#RI-4718 - fix unhandled error issue in recommendations #2351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 25 additions & 20 deletions redisinsight/api/src/modules/database-recommendation/database-recommendation.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,28 +61,33 @@ export class DatabaseRecommendationService {
recommendationName: string,
data: any,
): Promise<DatabaseRecommendation> {
const newClientMetadata = {
...clientMetadata,
db: clientMetadata.db ?? (await this.databaseService.get(clientMetadata.databaseId))?.db ?? 0,
};
const isRecommendationExist = await this.databaseRecommendationRepository.isExist(
newClientMetadata,
recommendationName,
);
if (!isRecommendationExist) {
const recommendation = await this.scanner.determineRecommendation(recommendationName, data);

if (recommendation) {
const entity = plainToClass(
DatabaseRecommendation,
{ databaseId: newClientMetadata?.databaseId, ...recommendation },
);

return await this.create(newClientMetadata, entity);
try {
const newClientMetadata = {
...clientMetadata,
db: clientMetadata.db ?? (await this.databaseService.get(clientMetadata.databaseId))?.db ?? 0,
};
const isRecommendationExist = await this.databaseRecommendationRepository.isExist(
newClientMetadata,
recommendationName,
);
if (!isRecommendationExist) {
const recommendation = await this.scanner.determineRecommendation(recommendationName, data);

if (recommendation) {
const entity = plainToClass(
DatabaseRecommendation,
{ databaseId: newClientMetadata?.databaseId, ...recommendation },
);

return await this.create(newClientMetadata, entity);
}
}
}

return null;
return null;
} catch (e) {
this.logger.warn('Unable to check recommendation', e);
return null;
}
}

/**
Expand Down