Fix/xhr error message #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| newSocket.on(SocketEvent.ConnectionError, (error: Error) => { | ||
| payloads.push({ isError: true, time: `${Date.now()}`, message: `${error?.name}: ${error?.message}` }) | ||
| newSocket.on(SocketEvent.ConnectionError, (error: { type: string; name: any; message: any }) => { | ||
| if (error?.type === 'TransportError') { |
There was a problem hiding this comment.
Could you create a enum for constant string? May be in the future any type will added
There was a problem hiding this comment.
and better to use switch case instead of else if in the future
There was a problem hiding this comment.
Could you create a enum for constant string? May be in the future any type will added
done
There was a problem hiding this comment.
and better to use switch case instead of
else ifin the future
according to the eslint rules, we must have at least one else if, otherwise the swith construct is useless (as in current case)
egor-zalenski
approved these changes
Jan 28, 2022
rsergeenko
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#RI-2356 - specify a human-readable error message