More dependabot fixes #2425
Merged
More dependabot fixes #2425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of protobufjs doesn't include any breaking changes to rawproto based on the functions by it.
vlad-dargel
suggested changes
Aug 4, 2023
There was a problem hiding this comment.
@GnaneshKunal can you return back testcafe version (discard tests/e2e/package.json and tests/e2e/yarn.lock)?
there is an issue in testCafe 3.1.0+ DevExpress/testcafe#7886 which fails our 23 e2e tests
vlad-dargel
approved these changes
Aug 7, 2023
rsergeenko
reviewed
Aug 7, 2023
| "electron-builder/app-builder-lib/@electron/universal/dir-compare/minimatch": "^3.0.5" | ||
| "electron-builder/app-builder-lib/@electron/universal/dir-compare/minimatch": "^3.0.5", | ||
| "**/semver": "^7.5.2", | ||
| "rawproto/protobufjs": "^7.2.4" |
There was a problem hiding this comment.
Is this version compatible with "rawproto": "^0.7.6"?
There was a problem hiding this comment.
Looking into this. Basic RI UI test did pass. Running tests/same code from the library
There was a problem hiding this comment.
Ran rawproto tests. Worked fine for protobuf ^7.2.4
rsergeenko
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes