add api key adding #2452
Merged
add api key adding #2452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-dargel
suggested changes
Aug 10, 2023
tests/e2e/helpers/api/api-keys.ts
Outdated
| requestBody | ||
| ); | ||
|
|
||
| console.log(JSON.stringify(response)); |
There was a problem hiding this comment.
do you need this console.log?
tests/e2e/helpers/api/api-keys.ts
Outdated
| .map((member) => ({ ...member, name: Buffer.from(member.name, 'utf-8') })) | ||
| }; | ||
|
|
||
| console.log(JSON.stringify(requestBody)); |
There was a problem hiding this comment.
do you need this console.log?
| * @param element The element in list | ||
| */ | ||
| export type ListKeyParameters = { | ||
| export type ListAndStringKeyParameters = { |
There was a problem hiding this comment.
I don't think that this is a good practice to combine two types in one
for list key we have keyName and element
for string key we have keyName and value
vlad-dargel
reviewed
Aug 11, 2023
tests/e2e/helpers/api/api-keys.ts
Outdated
| import { | ||
| HashKeyParameters, | ||
| ListKeyParameters, | ||
| ListAndStringKeyParameters, |
There was a problem hiding this comment.
ListAndStringKeyParameters
tests/e2e/helpers/api/api-keys.ts
Outdated
| */ | ||
| async addListKeyApi( | ||
| keyParameters: ListKeyParameters, | ||
| keyParameters: ListAndStringKeyParameters, |
There was a problem hiding this comment.
ListAndStringKeyParameters
tests/e2e/helpers/api/api-keys.ts
Outdated
| * @param databaseParameters The database parameters | ||
| */ | ||
| async addStringKeyApi( | ||
| keyParameters: ListAndStringKeyParameters, |
There was a problem hiding this comment.
ListAndStringKeyParameters
vlad-dargel
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.