Skip to content

Fix BE tests for relase #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Fix BE tests for relase #2489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12f5a5b
add additional env to circle ci
Aug 18, 2023
46259bc
possible fix ITests
Aug 18, 2023
e367c55
proper fix
Aug 18, 2023
a4d8ee5
keep the same order for be tests
Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions redisinsight/api/src/modules/server/server.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ describe('ServerService', () => {
anonymousId: mockServer.id,
sessionId,
appType: SERVER_CONFIG.buildType,
appVersion: SERVER_CONFIG.appVersion,
controlNumber: mockControlNumber,
controlGroup: mockControlGroup,
},
Expand Down
18 changes: 11 additions & 7 deletions redisinsight/api/test/api/feature/GET-features.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,16 @@ const updateSettings = (data) => request(server).patch('/settings').send(data);

const mainCheckFn = getMainCheckFn(endpoint);

const waitForFlags = async (flags: any) => {
const waitForFlags = async (flags: any, action?: Function) => {
const client = await getSocket('');

await new Promise((res, rej) => {
try {
action?.()?.catch(rej);
} catch (e) {
rej(e);
}

client.once('features', (data) => {
expect(flags).to.deep.eq(data);
res(true);
Expand Down Expand Up @@ -61,7 +67,7 @@ describe('GET /features', () => {

// remove all configs
await featureConfigRepository.delete({});
await syncEndpoint();
await featureRepository.delete({});
await waitForFlags({
features: {
insightsRecommendations: {
Expand All @@ -73,7 +79,7 @@ describe('GET /features', () => {
name: 'cloudSso',
},
},
});
}, syncEndpoint);
},
statusCode: 200,
responseBody: {
Expand Down Expand Up @@ -111,7 +117,6 @@ describe('GET /features', () => {

// remove all configs

await syncEndpoint();
await waitForFlags({
features: {
insightsRecommendations: {
Expand All @@ -123,7 +128,7 @@ describe('GET /features', () => {
name: 'cloudSso',
},
},
});
}, syncEndpoint);
},
statusCode: 200,
responseBody: {
Expand Down Expand Up @@ -164,7 +169,6 @@ describe('GET /features', () => {
},
})).catch(console.error);

await syncEndpoint();
await waitForFlags({
features: {
insightsRecommendations: {
Expand All @@ -176,7 +180,7 @@ describe('GET /features', () => {
name: 'cloudSso',
},
},
});
}, syncEndpoint);
},
statusCode: 200,
responseBody: {
Expand Down