Skip to content

#RI-4960 - ms not changed to msec in No Slow Logs message #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023
+10 −1
Merged

#RI-4960 - ms not changed to msec in No Slow Logs message #2580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions redisinsight/ui/src/pages/slowLog/components/EmptySlowLog/EmptySlowLog.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,11 @@ describe('EmptySlowLog', () => {
<EmptySlowLog durationUnit={DurationUnits.milliSeconds} slowlogLogSlowerThan={100} />
)).toBeTruthy()
})
it('should contain msec instead of ms', () => {
const { container } = render(
<EmptySlowLog durationUnit={DurationUnits.milliSeconds} slowlogLogSlowerThan={10000000} />
)

expect(container).toHaveTextContent('10 000 msec')
})
})
4 changes: 3 additions & 1 deletion redisinsight/ui/src/pages/slowLog/components/EmptySlowLog/EmptySlowLog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ const EmptySlowLog = (props: Props) => {
</EuiTitle>
<EuiText color="subdued">
Either no commands exceeding&nbsp;
{numberWithSpaces(convertNumberByUnits(slowlogLogSlowerThan, durationUnit))} {durationUnit}
{numberWithSpaces(convertNumberByUnits(slowlogLogSlowerThan, durationUnit))}
&nbsp;
{durationUnit === DurationUnits.milliSeconds ? DurationUnits.mSeconds : DurationUnits.microSeconds}
&nbsp;were found or Slow Log is disabled on the server.
</EuiText>
</div>
Expand Down