Skip to content

e2e updates for slowlog tests #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2023
Merged

e2e updates for slowlog tests #2598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tests/e2e/tests/critical-path/slow-log/slow-log.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ test('Verify that user can open new Slow Log page using new icon on left app pan
// Verify that user see "Slow Log" page by default for non OSS Cluster
await t.expect(overviewPage.overviewTab.withAttribute('aria-selected', 'true').exists).notOk('The Overview tab is displayed for non OSS Cluster db');
// Verify that user can configure slowlog-max-len for Slow Log and see whole set of commands according to the setting
await slowLogPage.changeSlowerThanParameter(slowerThanParameter);
await slowLogPage.changeSlowerThanParameter(slowerThanParameter, slowLogPage.slowLogConfigureMicroSecondsUnit);
await slowLogPage.Cli.sendCommandInCli(command);
await t.click(slowLogPage.slowLogRefreshButton);
const duration = await slowLogPage.slowLogCommandValue.withExactText(command).parent(3).find(slowLogPage.cssSelectorDurationValue).textContent;
Expand All @@ -50,21 +50,21 @@ test('Verify that user can see "No Slow Logs found" message when slowlog-max-len
await t.expect(slowLogPage.slowLogEmptyResult.exists).ok('Empty results not found');
// Verify that user can see not more that number of commands that was specified in configuration
maxCommandLength = 30;
await slowLogPage.changeSlowerThanParameter(slowerThanParameter);
await slowLogPage.changeSlowerThanParameter(slowerThanParameter, slowLogPage.slowLogConfigureMicroSecondsUnit);
await slowLogPage.changeMaxLengthParameter(maxCommandLength);
// Go to Browser page to scan keys and turn back
await t.click(myRedisDatabasePage.NavigationPanel.browserButton);
await t.click(browserPage.refreshKeysButton);
await t.click(myRedisDatabasePage.NavigationPanel.analysisPageButton);
await t.click(slowLogPage.slowLogTab);
// Compare number of logged commands with maxLength
await t.expect(slowLogPage.slowLogCommandStatistics.withText(`${maxCommandLength} entries`).exists).ok('Number of displayed commands is less than ');
await t.expect(slowLogPage.slowLogCommandStatistics.withText(`${maxCommandLength} entries`).exists).ok(`Number of displayed commands is less than selected ${maxCommandLength}`);
});
test('Verify that users can specify number of commands that they want to display (10, 25, 50, 100, Max) in Slow Log', async t => {
maxCommandLength = 128;
const numberOfCommandsArray = [10, 25, 50, 100, -1];
// Change slower-than parameter
await slowLogPage.changeSlowerThanParameter(slowerThanParameter);
await slowLogPage.changeSlowerThanParameter(slowerThanParameter, slowLogPage.slowLogConfigureMicroSecondsUnit);
await slowLogPage.changeMaxLengthParameter(maxCommandLength);
// Go to Browser page to scan keys and turn back
await t.click(myRedisDatabasePage.NavigationPanel.browserButton);
Expand All @@ -83,7 +83,7 @@ test('Verify that users can specify number of commands that they want to display
});
test('Verify that user can set slowlog-log-slower-than value in milliseconds and command duration will be re-calculated to ms', async t => {
// Set slower than parameter to log commands
await slowLogPage.changeSlowerThanParameter(slowerThanParameter);
await slowLogPage.changeSlowerThanParameter(slowerThanParameter, slowLogPage.slowLogConfigureMicroSecondsUnit);
// Send command in microseconds
command = 'scan 0 MATCH * COUNT 5000';
await slowLogPage.Cli.sendCommandInCli(command);
Expand Down Expand Up @@ -111,7 +111,7 @@ test('Verify that user can set slowlog-log-slower-than value in milliseconds and
test('Verify that user can reset settings to default on Slow Log page', async t => {
// Set slowlog-max-len=0
command = 'info';
await slowLogPage.changeSlowerThanParameter(slowerThanParameter);
await slowLogPage.changeSlowerThanParameter(slowerThanParameter, slowLogPage.slowLogConfigureMicroSecondsUnit);
await slowLogPage.Cli.sendCommandInCli('info');
await t.click(slowLogPage.slowLogRefreshButton);
await t.expect(slowLogPage.slowLogCommandValue.withExactText(command).exists).ok('Logged command not found');
Expand All @@ -121,11 +121,11 @@ test('Verify that user can reset settings to default on Slow Log page', async t
await t.expect(slowLogPage.slowLogEmptyResult.exists).ok('Slow log is not cleared');

// Set slower than parameter and max length
await slowLogPage.changeSlowerThanParameter(slowerThanParameter);
await slowLogPage.changeSlowerThanParameter(slowerThanParameter, slowLogPage.slowLogConfigureMicroSecondsUnit);
await slowLogPage.changeMaxLengthParameter(maxCommandLength);
// Reset settings to default
await slowLogPage.resetToDefaultConfig();
// Compare configuration after re-setting
const configText = await slowLogPage.configInfo.textContent;
await t.expect(configText.replace(/\u00a0/g, ' ')).contains('Execution time: 10 000 µs, Max length: 128', 'Not reset configuration');
await t.expect(configText.replace(/\u00a0/g, ' ')).contains('Execution time: 10 msec, Max length: 128', 'Not reset configuration');
});