Skip to content

E2e/bugfix/fix for regression #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2023
Merged

E2e/bugfix/fix for regression #2657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7211817
fix for regression tests
mariasergeenko Oct 3, 2023
d34e35f
fix for regression tests #2
mariasergeenko Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/e2e/tests/critical-path/tree-view/tree-view.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ fixture `Tree view verifications`
});
test('Verify that user can see that "Tree view" mode is enabled state is saved when refreshes the page', async t => {
// Verify that when user opens the application he can see that Tree View is disabled by default(Browser is selected by default)
await t.expect(browserPage.browserViewButton.getStyleProperty('background-color')).eql('rgb(215, 227, 250)', 'The Browser is not selected by default');
await t.expect(browserPage.browserViewButton.getStyleProperty('background-color')).eql('rgb(41, 47, 71)', 'The Browser is not selected by default');
await t.expect(browserPage.treeViewArea.exists).notOk('The tree view is displayed', { timeout: 10000 });

await t.click(browserPage.treeViewButton);
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/critical-path/url-handling/url-handling.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ test
};

await t.navigateTo(generateLink(connectUrlParams));
await t.wait(3_000);
await t.wait(7_000);
await t.expect(await workbenchPage.closeEnablementPage.exists).ok('Redirection to Workbench tutorial is not correct');

//Verify that the same db is not added
Expand Down
8 changes: 4 additions & 4 deletions tests/e2e/tests/regression/insights/feature-flag.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ test('Verify that default config applied when remote config version is lower', a

const featureVersion = await JSON.parse(await getColumnValueFromTableInDB(featuresConfigTable, 'data')).version;

await t.expect(featureVersion).eql(2.3401, 'Config with lowest version applied');
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).notOk('Insights panel displayed when disabled in default config');
await t.expect(featureVersion).eql(2.3402, 'Config with lowest version applied');
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).ok('Insights panel displayed when disabled in default config');
});
test('Verify that invaid remote config not applied even if its version is higher than in the default config', async t => {
// Update remote config .json to invalid
Expand All @@ -54,8 +54,8 @@ test('Verify that invaid remote config not applied even if its version is higher

const featureVersion = await JSON.parse(await getColumnValueFromTableInDB(featuresConfigTable, 'data')).version;

await t.expect(featureVersion).eql(2.3401, 'Config highest version not applied');
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).notOk('Insights panel displayed when disabled in default config');
await t.expect(featureVersion).eql(2.3402, 'Config highest version not applied');
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).ok('Insights panel displayed when disabled in default config');
});
test
.before(async() => {
Expand Down