Skip to content

e2e/feature/RI-4481_hide_database_passwords #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2023
Merged

e2e/feature/RI-4481_hide_database_passwords #2677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5604b8
updates for e2e
vlad-dargel Oct 11, 2023
2215262
update by pr comment
vlad-dargel Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/e2e/tests/web/critical-path/database/clone-databases.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ test
await myRedisDatabasePage.reloadPage();
})
.meta({ rte: rte.sentinel })('Verify that user can clone Sentinel', async t => {
const hiddenPassword = '************';

await databaseHelper.clickOnEditDatabaseByName(ossSentinelConfig.masters[1].alias);
await t.click(myRedisDatabasePage.AddRedisDatabase.cloneDatabaseButton);

Expand All @@ -120,7 +122,7 @@ test
await t
.click(myRedisDatabasePage.AddRedisDatabase.cloneSentinelNavigation)
.expect(myRedisDatabasePage.AddRedisDatabase.portInput.getAttribute('value')).eql(ossSentinelConfig.sentinelPort, 'Invalid sentinel port')
.expect(myRedisDatabasePage.AddRedisDatabase.passwordInput.getAttribute('value')).eql(ossSentinelConfig.sentinelPassword, 'Invalid sentinel password');
.expect(myRedisDatabasePage.AddRedisDatabase.passwordInput.getAttribute('value')).eql(hiddenPassword, 'Invalid sentinel password');
// Clone Sentinel Primary Group
await t.click(myRedisDatabasePage.AddRedisDatabase.addRedisDatabaseButton);
await t.expect(myRedisDatabasePage.dbNameList.withExactText(ossSentinelConfig.masters[1].alias).count).gt(1, 'Primary Group was not cloned');
Expand Down
12 changes: 7 additions & 5 deletions tests/e2e/tests/web/critical-path/database/import-databases.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ const dbData = [
}
];
const findImportedRdmDbNameInList = async(dbName: string): Promise<string> => rdmData.dbImportedNames.find(item => item === dbName)!;
const hiddenPassword = '************';

fixture `Import databases`
.meta({ type: 'critical_path', rte: rte.none })
Expand Down Expand Up @@ -152,8 +153,8 @@ test('Connection import from JSON', async t => {
// Verify username imported
await t.expect(myRedisDatabasePage.AddRedisDatabase.usernameInput.value).eql(rdmListOfDB[1].username, 'Username import incorrect');
// Verify password imported
await t.click(myRedisDatabasePage.AddRedisDatabase.showPasswordBtn);
await t.expect(myRedisDatabasePage.AddRedisDatabase.passwordInput.value).eql(rdmListOfDB[1].auth, 'Password import incorrect');
// Verify that user can see 12 hidden characters regardless of the actual database password when it is set
await t.expect(myRedisDatabasePage.AddRedisDatabase.passwordInput.value).eql(hiddenPassword, 'Password import incorrect');

// Verify cluster connection type imported
await databaseHelper.clickOnEditDatabaseByName(rdmData.dbImportedNames[2]);
Expand Down Expand Up @@ -256,11 +257,12 @@ test('Import SSH parameters', async t => {
await t.expect(myRedisDatabasePage.AddRedisDatabase.sshHostInput.value).eql(racompListOfSSHDB[0].sshHost, 'SSH host import incorrect');
await t.expect(myRedisDatabasePage.AddRedisDatabase.sshPortInput.value).eql((racompListOfSSHDB[0].sshPort).toString(), 'SSH port import incorrect');
await t.expect(myRedisDatabasePage.AddRedisDatabase.sshUsernameInput.value).eql(racompListOfSSHDB[0].sshUser, 'SSH username import incorrect');
await t.expect(myRedisDatabasePage.AddRedisDatabase.sshPasswordInput.value).eql(racompListOfSSHDB[0].sshPassword, 'SSH password import incorrect');
// Verify that password, passphrase and private key are hidden for SSH option
await t.expect(myRedisDatabasePage.AddRedisDatabase.sshPasswordInput.value).eql(hiddenPassword, 'SSH password import incorrect');

await databaseHelper.clickOnEditDatabaseByName(racompListOfSSHDB[1].name);
// Verify that user can import the SSH Private Key both by its value specified in the file and by the file path
await t.expect(myRedisDatabasePage.AddRedisDatabase.sshPrivateKeyInput.textContent).contains(sshPrivateKey, 'SSH Private key import incorrect');
await t.expect(myRedisDatabasePage.AddRedisDatabase.sshPrivateKeyInput.textContent).contains(hiddenPassword, 'SSH Private key import incorrect');
// Verify that user can import the SSH parameters with Passcode
await t.expect(myRedisDatabasePage.AddRedisDatabase.sshPassphraseInput.value).eql(racompListOfSSHDB[1].sshKeyPassphrase, 'SSH Passphrase import incorrect');
await t.expect(myRedisDatabasePage.AddRedisDatabase.sshPassphraseInput.value).eql(hiddenPassword, 'SSH Passphrase import incorrect');
});