Skip to content

Conversation

nelsonwellsredis
Copy link
Contributor

…of slim

Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan any optimizations in scope of this task?

docker-entry.sh Outdated
sleep 1
eval "$(echo "$GNOME_KEYRING_PASS" | gnome-keyring-daemon --start)"
echo "Running docker-entry.sh as:"
whoami
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am "node" :)

Copy link
Contributor

@vlad-dargel vlad-dargel Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also e2e tests fail with different reasons:

  1. Looks like Encryption doesn't work - its option in settings is disabled
  2. Something with Namespaces sorting on Database analysis page
  3. Profiler logs not saved
  4. RE Cluster doesn't work
  5. SQLITE_ERROR: no such table: features_config when test is trying to find table in db
  6. Wrong number of imported connections test. Looks like some connections were failed
  7. TLS certificates empty on connections import. The same is with connections with SSH.
  8. New published notification not displayed
  9. EACCES: permission denied. mkdir 'tmp/RedisInsight-v2' when uploading custom tutorials

@nelsonwellsredis nelsonwellsredis force-pushed the feature/RI-5036/optimize-docker-image branch from e7e1a96 to 2068f67 Compare November 7, 2023 18:49
ArtemHoruzhenko
ArtemHoruzhenko previously approved these changes Nov 8, 2023
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nelsonwellsredis nelsonwellsredis force-pushed the feature/RI-5036/optimize-docker-image branch from c0b0028 to 5576e8d Compare November 14, 2023 19:56
Artem and others added 26 commits November 24, 2023 15:44
…e-docker-image-review-fix

fix comments add tests
…encryption

Be/feature/ri 5072 docker encryption
…e-docker-image

define BASE_API_URL env for FE
…e-docker-image

rename envs to match common pattern
…ze-docker-image

E2e/feature/ri 5036/optimize docker image
# Conflicts:
#	redisinsight/api/config/default.ts
#	redisinsight/api/src/modules/bulk-actions/bulk-import.service.ts
#	redisinsight/api/test/helpers/remote-server.ts
#	tests/e2e/package.json
@ArtemHoruzhenko ArtemHoruzhenko merged commit c385cef into main Jan 12, 2024
@ArtemHoruzhenko ArtemHoruzhenko deleted the feature/RI-5036/optimize-docker-image branch January 12, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants