Skip to content

#RI-5122 - string value truncate #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2023
Merged

#RI-5122 - string value truncate #2756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions redisinsight/ui/src/pages/browser/components/string-details/StringDetails.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,34 @@ describe('StringDetails', () => {
})
})

it('Should add "..." in the end of the part value', async () => {
const stringDataSelectorMock = jest.fn().mockReturnValue({
value: partValue
})
stringDataSelector.mockImplementation(stringDataSelectorMock)

render(
<StringDetails
{...instance(mockedProps)}
/>
)
expect(screen.getByTestId(STRING_VALUE)).toHaveTextContent(`${bufferToString(partValue)}...`)
})

it('Should not add "..." in the end of the full value', async () => {
const stringDataSelectorMock = jest.fn().mockReturnValue({
value: fullValue
})
stringDataSelector.mockImplementation(stringDataSelectorMock)

render(
<StringDetails
{...instance(mockedProps)}
/>
)
expect(screen.getByTestId(STRING_VALUE)).toHaveTextContent(bufferToString(fullValue))
})

it('should call fetchDownloadStringValue and sendEventTelemetry after clicking on load button and download button', async () => {
const stringDataSelectorMock = jest.fn().mockReturnValue({
value: partValue
Expand Down
2 changes: 1 addition & 1 deletion redisinsight/ui/src/pages/browser/components/string-details/StringDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ const StringDetails = (props: Props) => {
const { value: formattedValue, isValid } = formattingBuffer(decompressedValue, viewFormatProp, { expanded: true })
setAreaValue(initialValueString)

setValue(formattedValue)
setValue(!isFullStringLoaded(initialValue?.data?.length, length) ? `${formattedValue}...` : formattedValue)
setIsValid(isValid)
setIsDisabled(
!isNonUnicodeFormatter(viewFormatProp, isValid)
Expand Down