Skip to content

fix for zset formatter #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix for zset formatter #2821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/e2e/tests/web/critical-path/browser/formatters.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ notEditableFormattersSet.forEach(formatter => {
// Verify for Protobuf, Java serialized, Pickle
// Verify for Hash, List, ZSet, String keys
for (const key of keysData) {
if (key.textType === 'Hash' || key.textType === 'List' || key.textType === 'Sorted Set' || key.textType === 'String') {
if (key.textType === 'Hash' || key.textType === 'List' || key.textType === 'String') {
const editBtn = (key.textType === 'String')
? browserPage.editKeyValueButton
: Selector(`[data-testid*=edit-][data-testid*=${key.keyName.split('-')[0]}]`, { timeout: 500 });
Expand All @@ -206,6 +206,13 @@ notEditableFormattersSet.forEach(formatter => {
// Verify tooltip content
await t.expect(browserPage.tooltip.textContent).contains('Cannot edit the value in this format', 'Tooltip has wrong text');
}
if (key.textType === 'Sorted Set') {
const editBtn = Selector(`[data-testid*=edit-][data-testid*=${key.keyName.split('-')[0]}]`, { timeout: 500 });
await browserPage.openKeyDetailsByKeyName(key.keyName);
await browserPage.selectFormatter(formatter.format);
// Verify that edit button enabled for ZSet
await t.expect(editBtn.hasAttribute('disabled')).notOk(`Key ${key.textType} is disabled for ${formatter.format} formatter`);
}
}
});
});